After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661113 - Some patches to h264parse
Some patches to h264parse
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-06 18:26 UTC by sreerenj
Modified: 2011-10-17 09:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Correct the parsing of "numberOfPictureParameterSets". (927 bytes, patch)
2011-10-06 18:27 UTC, sreerenj 		committed Details | Review
use GST_READ_UINT16_BE() to read the sequeceParameterSetLength and pictureParameterSetLength. (3.37 KB, patch)
2011-10-06 18:27 UTC, sreerenj 		none Details | Review
Correcting the debug message and remove the dead code. (1.23 KB, patch)
2011-10-13 14:10 UTC, sreerenj 		committed Details | Review

Description sreerenj 2011-10-06 18:26:29 UTC 
patch1:Correct the parsing of "numberOfPictureParameterSets".

patch2: use GST_READ_UINT16_BE() to read the sequeceParameterSetLength and pictureParameterSetLength.
Comment 1 sreerenj 2011-10-06 18:27:09 UTC 
Created attachment 198462 [details] [review]
Correct the parsing of "numberOfPictureParameterSets".
Comment 2 sreerenj 2011-10-06 18:27:40 UTC 
Created attachment 198463 [details] [review]
 use GST_READ_UINT16_BE() to read the sequeceParameterSetLength and pictureParameterSetLength.
Comment 3 sreerenj 2011-10-13 14:08:37 UTC 
patch2 is obsolete based on commit f94236078cd38d3e881d80e7e89cef86be03c921. 

patch1 has a high priority i think, since the current code wrongly calculating the numerOfPictureParameterSets.

Adding one minor patch also.
Comment 4 sreerenj 2011-10-13 14:10:04 UTC 
Created attachment 198937 [details] [review]
Correcting the debug message and remove the dead code.
Comment 5 Mark Nauwelaerts 2011-10-17 09:24:03 UTC 
Thanks, committed (with minor tweak in second one):

commit f8239ff6924c7e03af73707ef5fd9e218c0f9f5c
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Thu Oct 13 16:52:43 2011 +0300

    h264parse: correct debug message and remove some dead code
    
    See #661113.

commit 0a478db7dd5909f8f7281db352b227965c45e094
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Thu Oct 6 16:55:43 2011 +0300

    h264parse: correct parsing of "numberOfPictureParameterSets"
    
    See #661113.