GNOME Bugzilla – Bug 661062
No way to get client-id from a GoaAccount
Last modified: 2011-10-08 20:23:04 UTC
For facebook XMPP auth, we need the client-id used to get the oauth2 access-token. GoaAccount should explose it in its DBus API.
Yes, we should probably expose both client_id and client_secret, e.g. http://developer.gnome.org/goa/unstable/GoaOAuth2Provider.html#goa-oauth2-provider-get-client-id http://developer.gnome.org/goa/unstable/GoaOAuth2Provider.html#goa-oauth2-provider-get-client-secret as D-Bus properties the same way we do this for OAuth1, e.g. http://developer.gnome.org/goa/unstable/gdbus-org.gnome.OnlineAccounts.OAuthBased.html#gdbus-property-org-gnome-OnlineAccounts-OAuthBased.ConsumerKey http://developer.gnome.org/goa/unstable/gdbus-org.gnome.OnlineAccounts.OAuthBased.html#gdbus-property-org-gnome-OnlineAccounts-OAuthBased.ConsumerSecret
Created attachment 198562 [details] [review] GoaOAuth2Based: Add ClientId and ClientSecret properties
Review of attachment 198562 [details] [review]: Looks good except that it's missing additions to the doc/goa-sections.txt file. Good to commit with that change. Thanks!
(In reply to comment #3) > Review of attachment 198562 [details] [review]: > > Looks good except that it's missing additions to the doc/goa-sections.txt file. > Good to commit with that change. Thanks! (That's be, set_, get_ and dup_ for each added property, btw.)
Created attachment 198565 [details] [review] GoaOAuth2Based: Add ClientId and ClientSecret properties
Comment on attachment 198565 [details] [review] GoaOAuth2Based: Add ClientId and ClientSecret properties OK. This assumes that client_id and client_secret are both UTF-8 strings but IIRC this is OK. If it turns out to not to be true we can always change it to 'ay' later. Please commit. Thanks.
merged.