GNOME Bugzilla – Bug 661044
Follow the icon-theme/naming-specification
Last modified: 2020-11-12 14:27:31 UTC
Lets split the icons into those used for the tray, and those used for the applet-interface. The icons for the applet-interface remain where they are: "../scalable/apps/" The icons for the status tray go to: "../scalable/status/" The guidelines are followed, and everyone is happy! Use case: users with a white theme and a black status tray, or a black theme and a white status tray. This way, icon themes can customize the status icon color *and* the applet icon color differently.
Icon themes can customize whatever they want, regardless of where the icon sits in the file system.
Created attachment 198641 [details] [review] Split status icons and apps icons Untested, but should work. Doesn't remove obsolete application icons (that are now status icons).
But themes can't customize the same icon with different appearances. Hence attached patch.
Created attachment 198665 [details] [review] Fix typo and update configure.ac for split icon layout
Created attachment 198666 [details] [review] Add nm-stage* status icons originally missed
Tested and work as expected, with all three patches (above) applied. The general idea is to . Append _status to GdkPixbuf* status icon resource names . Append _status to functions that modify the status icon . Split functions (only 1) that do both into _status and non-status versions ------- . install icons to icons/apps/ and icons/status/ . append -status to status icon names . functions that modify the status icon load -status icon versions I identified all the icons possibly loaded into the status tray, and duplicated those resources (actual icons and GdkPixbuf* names) without verifying if those icons are loaded only into the status tray. I know the nm-signal* icons are used for both the tray and the menu, ie the variants nm-signal%02d and nm-signal%02d-status are needed. It is possible all the other status icons are only used in the status tray, in which case their corresponding menu entries (actual icons and GdkPixbuf*) can be deleted. However, thats a lot of work for someone who is unfamiliar with nm-applet (but probably simple enough for those familiar). And these patches work. So I'm leaving it the way it is.
bump?
...
Rebased this on top of master and compile-checked. This possibly needs some more work: as reporter indicates some icons are probably duplicated. Also the _status naming change seems a bit useless at least in some places to me. Pushed into lr/icon-naming-fdo661044
bugzilla.gnome.org is being shut down in favor of a GitLab instance. We are closing all old bug reports and feature requests in GNOME Bugzilla which have not seen updates for a long time. If you still use NetworkManager and if you still see this bug / want this feature in a recent and supported version of NetworkManager, then please feel free to report it at https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/ Thank you for creating this report and we are sorry it could not be implemented (workforce and time is unfortunately limited).