GNOME Bugzilla – Bug 660917
background image does not work
Last modified: 2011-10-28 10:08:37 UTC
It is possible to select an image but the image is not draw as background.
Seems the dialog is broken.
Actually things do work. You must first add an image to the document, choosing both a name and a file, and click the Add button. Then you can select the image by clicking on the thumbnail. I agree that it is not very intuitive.
@Jean, there are some issues though: The "Fit" combo is unnaturally high The icon to the right of the Fit combo and Select button seems out of place. If I click Select and again Select in the next dialog, choose a file and okay I end up at a dialog that hasn't changed. Clicking on Add, adds a tiny square in the top area... ??? What is that top white area goof for anyways. Note that Add button should really only be active when it really does something. When I type a name and select a file, the dialog does not show that I selected a file and clicking the add button just deletes the name! I will be adding to screen shots.
Created attachment 198250 [details] screen shot of chart properties dialog section
Created attachment 198253 [details] dialog after adding a file...?
If I add an image to the document, shouldn't that image be available for other fills?
And if you first insert the chart and then open it to add an image fill, there seem to be no sequence of actions that successfully adds the image fill.
OK, I need to investigate all these issues.
Pushed a fix. Please test again.
Hi! OK, I now see how it works. Still, I find the sequence very complicate: - why should we provide a name for the image? This really makes things more complex, because you cannot add an image when there is no name. At least, a message should inform the user about this. - and even, why is it not possible to go directly in the file selection dialog? It is what I was expecting.
I guess the idea is that you are likely to use the same image for fills in several graphs (or several parts of one or more graphs). So it is simpler to keep a listing of the images already imported into the document. When you are using an image as a fill you are not just specifying a file name but in fact are importing the fill into the document proper. (I would agree that there are lots of ways this could be improved!)
Created attachment 198377 [details] screenshot showing some issues Problems I see here: The Type, Fit etc. should really be immediately below the "Fill" header. The tiny icon is not understandable. Wouldn't it be better to simply say that no image is selected?!
Created attachment 198379 [details] screen shot of image selector I see several issues with this dialog: The primary item seems to be the "Add"... when it is really the listing at the top. If I select an image and then add a name the Add button stays insensitive. IT seems to become sensitive only if a first specify a name and then select the image. (Upon selection of an image we should probably construct a default name!) If I add an image the dialog does not change, so I am never sure whether I in fact selected one for addition or not... The ok button should not be active unless a image is in fact selected!
Created attachment 198380 [details] screen shot showing spacing issues there are clearly some spacing issues....
How do I delete an image from the list once I don't use it anymore for a fill?
(In reply to comment #12) > Created an attachment (id=198377) [details] > screenshot showing some issues > > Problems I see here: > > The Type, Fit etc. should really be immediately below the "Fill" header. Looks like one more gtk3 issue. Looks like gtk3 has issues when dealing with boxes and alignments inside each other. > The tiny icon is not understandable. Wouldn't it be better to simply say that > no image is selected?! Agreed.
Do we really need to delete images, we might just not save those that are not in use (which is not currently the case).
If we do not save (and do not show) images that are not in use, we obviously do not need a "delete", but the latter is required otherwise.
They will still show up in the list. Even adding a "delete" button needs a way to know if the image is actually used, otherwise we'll most probably get crashes. I'll add go_image_ref and go_image_unref. Btw, I'm currently trying to redesign the whole GOImage code in order to properly support svg (and possibly other vectorial drawings).
Actually unused images are not saved.
After more thinking, I believe that we actually don't need the "Add" button. If a file is selected, we should just add the new image to the doc with an automatic name if none is provided. This would make things easier, I suppose.
Jean, I agree. I think the first dialog should just give a list with the already added images and an "Other" button. The file selector started from the "Other button" could then include a name entry that is being pre-populated with the file name (+/- a counter).
I redesigned the image selector. May be we might request a larger size since only one thumbnail is visible at once with the default size. Please check. This leave the fill style page issues (comment #16).
I think this is a great improvement, but why, after selecting a new image, am I returned to the image selector? Since I just selected the image I want to use I should go directly back to the graph guru.
Also double clicking an image should really close teh dialog with that image selected. More importantly: Clicking twice (?) in the window close box of the image selector yields: Program received signal SIGSEGV, Segmentation fault. __libc_free (mem=0x4066e201) at malloc.c:3709 3709 malloc.c: No such file or directory. in malloc.c
+ Trace 228886
clicking once in the window close box of the image selector and then the okay button yields: Program received signal SIGSEGV, Segmentation fault. 0xb768dcd0 in gtk_icon_view_get_selected_items (icon_view=0x9e) at /build/buildd/gtk+3.0-3.0.8/./gtk/gtkiconview.c:5263 5263 /build/buildd/gtk+3.0-3.0.8/./gtk/gtkiconview.c: No such file or directo
+ Trace 228887
Issues described in comments #24-26 are (hopefully) fixed.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report. Looks like every thing works fine now. Feel free to reopen if you don't agree…