After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660881 - File selection: direction doesn't select file in next row
File selection: direction doesn't select file in next row
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.2.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 642322 664867 674597 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-04 14:10 UTC by Pedro Villavicencio
Modified: 2012-04-23 09:45 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2


Attachments
[keyboardability] Make 'next row' work again by making it general (5.39 KB, patch)
2011-12-02 14:43 UTC, Nelson Benitez
committed Details | Review

Description Pedro Villavicencio 2011-10-04 14:10:55 UTC
this report has been filed here:

https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/855862

"In Nautilus, when we traverse to the end of a row of files, earlier it used to continue to the first file of next row. However, in this release it just stops there, and we again have to go to the start of the row and then press down key to reach the first file of next row.

This is particularly annoying for users habituated with keyboards."
Comment 1 Mariusz Libera 2011-10-07 15:08:48 UTC
I can confirm, it is very very annoying regression. Please fix it.
Comment 2 Rafael K. Tesser 2011-10-24 01:26:50 UTC
I also confirm this problem. It would be nice to have it fixed.
Comment 3 Sebastien Bacher 2011-11-08 18:46:43 UTC
The issue was fixed back then in GNOME 2.24:
https://bugzilla.gnome.org/show_bug.cgi?id=526802

but got broken back in GNOME3
Comment 4 Sam Grönblom 2011-11-12 17:44:38 UTC
Yeah this sucks. It's like windows explorer now.
Comment 5 Cosimo Cecchi 2011-11-29 18:32:41 UTC
*** Bug 664867 has been marked as a duplicate of this bug. ***
Comment 6 Nelson Benitez 2011-12-02 14:43:08 UTC
Created attachment 202615 [details] [review]
[keyboardability] Make 'next row' work again by making it general

The problem is this behaviour was implemented only when no a11y is activated, the condition that checked if a11y was activated is now returning always true (even if org.gnome.desktop.interface.toolkit-accessibility key setting is false) so the behaviour is not executed.

I asked on a11y mailing list if this condition could be improved and they told me about the aforementioned key setting and also that the behaviour doesn't hurt a11y people cause AtkTable implementation will handle that.

Based on that last comment I'm attaching a patch that makes the behaviour work again by making it general in contrast to be restricted to no_a11y only.
Comment 8 Cosimo Cecchi 2011-12-02 15:34:59 UTC
Review of attachment 202615 [details] [review]:

Looks good; thanks for your time and the investigation on this bug!
Comment 9 Cosimo Cecchi 2011-12-02 23:18:03 UTC
*** Bug 642322 has been marked as a duplicate of this bug. ***
Comment 10 Nelson Benitez 2011-12-05 18:52:40 UTC
Comment on attachment 202615 [details] [review]
[keyboardability] Make 'next row' work again by making it general

Patch commited, thanks cosimo for your attention on the bug and sorry for the line endings bad formatted on the commit subject.
Comment 11 Nelson Benitez 2012-04-23 09:45:25 UTC
*** Bug 674597 has been marked as a duplicate of this bug. ***