After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660846 - menu-items: use a 16px size for the user menu icon
menu-items: use a 16px size for the user menu icon
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-04 00:40 UTC by Cosimo Cecchi
Modified: 2011-10-17 11:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
menu-items: use a 16px size for the user menu icon (986 bytes, patch)
2011-10-04 00:40 UTC, Cosimo Cecchi
reviewed Details | Review

Description Cosimo Cecchi 2011-10-04 00:40:53 UTC
See attached patch for the rationale
Comment 1 Cosimo Cecchi 2011-10-04 00:40:55 UTC
Created attachment 198171 [details] [review]
menu-items: use a 16px size for the user menu icon

The shell uses a 16px icon size too, and the icon looks kind of blurry
at 24px.
Comment 2 Vincent Untz 2011-10-04 06:50:22 UTC
Comment on attachment 198171 [details] [review]
menu-items: use a 16px size for the user menu icon

If the icon looks blurry at 24px, then it's a bug in the theme, really :-)

The issue here is that we use 24px icons in all other panel menus, and I feel it's weird to have this icon different from the others.
Comment 3 Cosimo Cecchi 2011-10-04 15:26:19 UTC
(In reply to comment #2)
> (From update of attachment 198171 [details] [review])
> If the icon looks blurry at 24px, then it's a bug in the theme, really :-)
> 
> The issue here is that we use 24px icons in all other panel menus, and I feel
> it's weird to have this icon different from the others.

Hmm, I understand...though, the notification area (which is right next to this icon) seems to use 16px symbolic icons for e.g. the sound and power applets.
Comment 4 Vincent Untz 2011-10-04 16:02:11 UTC
Yes, we use 16px icons in the notification area and 24px icons in menus.

I don't care much about the icon size in menus, as long as it's consistent :-)
Comment 5 Vincent Untz 2011-10-17 11:45:02 UTC
Okay, I changed my mind and fixed it another way which makes things consistent in other cases: http://git.gnome.org/browse/gnome-panel/commit/?id=12b371c4211ec5d17cf799cb3ee628ffd577cbf6