GNOME Bugzilla – Bug 660839
Workspace keyboard shortcut improvements
Last modified: 2012-06-27 18:19:29 UTC
These should be fairly straightforward patches. Some issues: 1. The second patch seems to make the workspace navigator "go crazy": it seems to allocate the list view and its children separately and get it wrong. Sometimes you'll see the indicator showing outside the bounds, and sometimes you'll get small little indicators on the top-left corner of itself. 2. The third patch seems to have some trouble with invisible borders: press the "move down" keyboard shortcut and the window actor will jump. I'm not sure if this is a mutter bug or not. 3. The third patch still has some issues. Moving a window "up", "down" very quickly will cause the window to snap to where it's supposed to be -- the behavior that happened before the patch.
Created attachment 198162 [details] [review] windowManager: Remove old keybindings for left/right workspace switching It's been dead code for a while.
Created attachment 198163 [details] [review] windowManager: Don't allow the user to hold <Control><Alt><Shift>Down While quite fun, it's confusing to new users and looks funky.
Created attachment 198164 [details] [review] windowManager: Hold the window on the stage while going between workspaces Right now the "move to workspace" keyboard shortcut transition isn't smooth. It shows the window disappearing, hopping to the next workspace, and then sliding into view. "Pin" the window to the stage while the animation is in progress, then release it afterwards.
(In reply to comment #0) > 2. The third patch seems to have some trouble with invisible borders: press the > "move down" keyboard shortcut and the window actor will jump. I'm not sure if > this is a mutter bug or not. This is bug #660848. Not sure what's causing it yet, reproducible with raw metacity.
*** Bug 641368 has been marked as a duplicate of this bug. ***
Created attachment 199335 [details] [review] windowManager: Animate the window changing between workspaces When a window is maximized or full-screened, it obstructs the workspace behind it, making it non-obvious that the window is actually switching workspaces. Animate the window moving before "moving the camera" so it's a bit more obvious that the user is switching workspaces.
Created attachment 199691 [details] [review] windowManager: Remove old keybindings for left/right workspace switching It's been dead code for a while. -- Apparently we can't just remove binding handler because then mutter's original will show through. Take over the entire keybinding.
Created attachment 199704 [details] [review] windowManager: Don't allow the user to hold <Control><Alt><Shift>Down While quite fun, it's confusing to new users and looks funky. -- Fix Ctrl+Alt+Shift+Down/Up not working in the overview.
Created attachment 217427 [details] [review] windowManager: Hold the window on the stage while going between workspaces Right now the "move to workspace" keyboard shortcut transition isn't smooth. It shows the window disappearing, hopping to the next workspace, and then sliding into view. "Pin" the window to the stage while the animation is in progress, then release it afterwards. Rebased on bug 674104
Created attachment 217428 [details] [review] windowManager: Animate the window changing between workspaces When a window is maximized or full-screened, it obstructs the workspace behind it, making it non-obvious that the window is actually switching workspaces. Animate the window moving before "moving the camera" so it's a bit more obvious that the user is switching workspaces. Rebased.
Review of attachment 217427 [details] [review]: Looks fine.
Review of attachment 217428 [details] [review]: I'm not entirely happy with this patch myself. What do you think about it?
Review of attachment 199704 [details] [review]: Needs a rebase.
(In reply to comment #12) > Review of attachment 217428 [details] [review]: > > I'm not entirely happy with this patch myself. What do you think about it? We show the workspace switcher now, so I don't think this is necessary. (In reply to comment #13) > Review of attachment 199704 [details] [review]: > > Needs a rebase. Isn't this obsoleted by the other bug?
Comment on attachment 217427 [details] [review] windowManager: Hold the window on the stage while going between workspaces Attachment 217427 [details] pushed as e43fe98 - windowManager: Hold the window on the stage while going between workspaces
(In reply to comment #14) > Isn't this obsoleted by the other bug? Yeah, I was pointing out why I was marking it rejected.
And sure, let's "fix" this