After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660826 - pyatspi-2.2.0 AM_CHECK_PYMOD in acinclude.m4 should not check for pygtk
pyatspi-2.2.0 AM_CHECK_PYMOD in acinclude.m4 should not check for pygtk
Status: RESOLVED FIXED
Product: pyatspi2
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Li Yuan
pyatspi2 maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-10-03 20:40 UTC by Alexandre Rostovtsev
Modified: 2015-02-27 16:40 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2

Attachments
Drop unneeded pygtk check from AM_CHECK_PYMOD (654 bytes, patch)
2011-10-03 20:43 UTC, Alexandre Rostovtsev 		accepted-commit_now Details | Review

Description Alexandre Rostovtsev 2011-10-03 20:40:58 UTC 
pyatspi2 no longer uses pygtk, but AM_CHECK_PYMOD in acinclude.m4 still checks for it.
Comment 1 Alexandre Rostovtsev 2011-10-03 20:43:05 UTC 
Created attachment 198154 [details] [review]
Drop unneeded pygtk check from AM_CHECK_PYMOD
Comment 2 Mike Gorse 2011-10-04 19:31:00 UTC 
Comment on attachment 198154 [details] [review]
Drop unneeded pygtk check from AM_CHECK_PYMOD

I'm not really sure why that check was even there.  Looks okay to me.  Do you have commit access, or would you like me to commit it?




>From 484a3285a5f66ab05ab030fc9217685f02052c91 Mon Sep 17 00:00:00 2001
>From: Alexandre Rostovtsev <tetromino@gmail.com>
>Date: Mon, 3 Oct 2011 16:32:23 -0400
>Subject: [PATCH] Drop unneeded pygtk check from AM_CHECK_PYMOD
>
>https://bugzilla.gnome.org/show_bug.cgi?id=660826
>---
> acinclude.m4 |    2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>diff --git a/acinclude.m4 b/acinclude.m4
>index 79c3c7c..6622932 100644
>--- a/acinclude.m4
>+++ b/acinclude.m4
>@@ -51,8 +51,6 @@ AC_CACHE_VAL(py_cv_mod_$py_mod_var, [
> ifelse([$2],[], [prog="
> import sys
> try:
>-	import pygtk
>-	pygtk.require('2.0')
> 	import $1
> except ImportError:
> 	sys.exit(1)
>-- 
>1.7.7
>
Comment 3 Alexandre Rostovtsev 2011-10-04 21:55:24 UTC 
(In reply to comment #2)
> (From update of attachment 198154 [details] [review])
> I'm not really sure why that check was even there.  Looks okay to me.  Do you
> have commit access, or would you like me to commit it?

Please commit it, I don't have commit access.
Comment 4 Mike Gorse 2012-01-21 10:40:52 UTC 
Sorry--I'd forgotten about this patch. Just pushed: cfc32a.
Comment 5 André Klapper 2015-02-27 16:40:37 UTC 
[Moving at-spi/pyatspi2 bugs to separate product. See bug 740075]