After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660818 - Banshee hangs on broken internet connection (UbuntuOneMusicStore extension bug)
Banshee hangs on broken internet connection (UbuntuOneMusicStore extension bug)
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Playback
2.2.0
Other Linux
: High critical
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
: 661692 661904 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-03 19:52 UTC by Johan van der Slikke
Modified: 2011-11-01 18:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Log of Banshee hang on failing internet connection. (11.92 KB, text/plain)
2011-10-10 05:01 UTC, Johan van der Slikke
Details

Description Johan van der Slikke 2011-10-03 19:52:36 UTC
1. Have an internet connection which is not working (in my case because of a router which drops packets silently, so the error is not reported)
2. I guess: have Last.fm scrobbling enabled
3. Start listening a song from your library
4. Note that Banshee is not responding anymore
Comment 1 Bertrand Lorentz 2011-10-09 11:54:04 UTC
Thanks for taking the time to report this bug.

We need more information to determine the cause of the problem.
Please follow the instructions in http://banshee.fm/contribute/file-bugs/ to provide us with additional information. Make sure you run the "kill ..." when Banshee is not responding.
Comment 2 Johan van der Slikke 2011-10-10 05:01:23 UTC
Created attachment 198695 [details]
Log of Banshee hang on failing internet connection.
Comment 3 Johan van der Slikke 2011-10-10 05:03:56 UTC
Comment on attachment 198695 [details]
Log of Banshee hang on failing internet connection.

For this log I was also able to reproduce the problem with not providing an DNS server.
Comment 4 Andrés G. Aragoneses (IRC: knocte) 2011-10-10 19:05:15 UTC
Thanks for the information.

If I'm not mistaken, this is a crash caused by this commit:

http://git.gnome.org/browse/banshee/commit/?id=b57437bb82d33e1415c50bba80be915b6f5352bc

So I guess the workaround is to disable the UbuntuOneMusicStore extension, Johan.

Alex, do you mind taking a look at the problem, since you wrote that change?

Thanks
Comment 5 Johan van der Slikke 2011-10-11 05:08:26 UTC
Disabling the UbuntuOneMusicStore extension indeed solves the problem. Thanks for that workaround. Good luck in solving the bug ;)
Comment 6 Andrés G. Aragoneses (IRC: knocte) 2011-10-14 22:36:36 UTC
*** Bug 661692 has been marked as a duplicate of this bug. ***
Comment 7 Andrés G. Aragoneses (IRC: knocte) 2011-10-17 16:42:47 UTC
*** Bug 661904 has been marked as a duplicate of this bug. ***
Comment 8 Andrés G. Aragoneses (IRC: knocte) 2011-10-19 12:20:28 UTC
Given Alex may be busy and this is a critical bug, I just committed a potential fix for this: http://git.gnome.org/browse/banshee/commit/?id=906735bb5b80c0456f014d189a6914ff6fe3fe57

Please report if git master doesn't this bug anymore so we can backport to the stable branch.
Comment 9 Chow Loong Jin 2011-10-21 03:59:23 UTC
According to https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/865697/comments/10, the fix works perfectly!
Comment 10 Andrés G. Aragoneses (IRC: knocte) 2011-10-21 07:58:15 UTC
(In reply to comment #9)
> According to
> https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/865697/comments/10, the
> fix works perfectly!

Thanks Chow, do we know if that is because of my fix or dobey's? I ask because IIRC dobey's fix to work requires of a new version of a library.
Comment 11 Chow Loong Jin 2011-10-21 09:08:01 UTC
Probably yours. The package that's currently in the banshee-daily PPA is built from commit 906735b which was your commit.
Comment 12 Rodney Dawes 2011-10-21 20:46:59 UTC
My fix doesn't require a new version of libubuntuone to work. It fixes this bug regardless of changes to libu1, because it simply removes the callback where the issue is occuring.
Comment 13 Andrés G. Aragoneses (IRC: knocte) 2011-10-24 17:35:15 UTC
*** Bug 662137 has been marked as a duplicate of this bug. ***
Comment 14 Bertrand Lorentz 2011-11-01 18:05:43 UTC
I'm marking this as fixed as:
- Both fixes from Andrés and Rodney are on git master
- The code causing the issue was not in the stable-2.2 branch, but in a patch applied to the Ubuntu package for 2.2.0. I have now committed a patch to stable-2.2 that brings the U1MS store up to what is in git master:

http://git.gnome.org/browse/banshee/commit/?h=stable-2.2&id=1346fcaf02