After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660774 - Avoid having "Name is now known as Name" for every messages.
Avoid having "Name is now known as Name" for every messages.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: telepathy
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Shell Telepathy maintainer(s)
gnome-shell-maint
: 660705 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-03 11:03 UTC by Ionut Biru
Modified: 2011-10-12 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.26 KB, patch)
2011-10-03 11:08 UTC, Ionut Biru 		none Details | Review
telepathyClient: Check for a no-op before pushing an alias change message (1.24 KB, patch)
2011-10-03 19:50 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Ionut Biru 2011-10-03 11:03:25 UTC 
with telepathy-glib 0.15.6 the signal is emitted even when the aliases are not different. Avoid pushing the notifications.

Example: http://ompldr.org/vYW10Zw

Patch attached.
Comment 1 Ionut Biru 2011-10-03 11:08:11 UTC 
Created attachment 198070 [details] [review]
fix
Comment 2 Xavier Claessens 2011-10-03 18:20:16 UTC 
The patch looks good.

Wondering why we have this.pushNotification(this._notification);
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-10-03 18:34:39 UTC 
(In reply to comment #2)
> Wondering why we have this.pushNotification(this._notification);

It was an old hack when we were still using DBus instead of tp-glib. It should be able to be removed, now.
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-10-03 19:50:10 UTC 
Created attachment 198144 [details] [review]
telepathyClient: Check for a no-op before pushing an alias change message

tp-glib can sometimes emit a notify::alias signal when the alias doesn't
actually change. Bail out early instead of pushing an alias change message.
Comment 5 Xavier Claessens 2011-10-05 19:30:40 UTC 
that patch looks good, please merge.
Comment 6 Jasper St. Pierre (not reading bugmail) 2011-10-05 19:35:03 UTC 
Attachment 198144 [details] pushed as d862c08 - telepathyClient: Check for a no-op before pushing an alias change message
Comment 7 Jasper St. Pierre (not reading bugmail) 2011-10-12 14:54:01 UTC 
*** Bug 660705 has been marked as a duplicate of this bug. ***