After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660748 - Cann't save attachment in event
Cann't save attachment in event
Status: RESOLVED FIXED
Product: evolution-ews
Classification: Other
Component: Calendar
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Evolution EWS maintainer(s)
Evolution EWS maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-10-03 05:27 UTC by Akhil Laddha
Modified: 2013-07-29 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for evolution-ews (3.30 KB, patch)
2012-03-20 11:06 UTC, Vibha Yadav
none Details | Review
ews patch (6.05 KB, patch)
2013-07-29 10:57 UTC, Milan Crha
committed Details | Review

Description Akhil Laddha 2011-10-03 05:27:58 UTC
Evolution 3.2 + Exchange 2007

1. New -> Appointment
2. Add an attachment
3 [details]. Fill summary, description
4. Save appointment
5. It will throw an error  - Could not save attachments , invalid filename
6. Event will be saved without attachment
Comment 1 Vibha Yadav 2012-03-14 06:44:15 UTC
I can attach files to events/appointments but when I reopen the event the attachment contains comp UID as prefix to attachment name.
Comment 2 Vibha Yadav 2012-03-20 11:06:31 UTC
Created attachment 210164 [details] [review]
Patch for evolution-ews

Patch for fetching attachments and renaming it appropriately.
Comment 3 Milan Crha 2013-07-29 07:43:17 UTC
Still reproduceable with git master, confirming. When I edit an old appointment with attachments and add a new one into it, then the save will not claim any error, but the attachments are removed from the event. The evolution's UI pretends everything is OK, but the OWA interface shows no attachments on the event. The calendar-factory console shows a runtime warning:
> ** (evolution-calendar-factory:3553): WARNING **: Error while creating
> attachments: Failed to open file 'file:///home/mcrha/.cache/evolution/
> calendar/xxx/<ews-id>-file.txt': No such file or directory
Comment 4 Milan Crha 2013-07-29 10:57:26 UTC
Created attachment 250358 [details] [review]
ews patch

for evolution-ews;

The previously attached patch doesn't work, unfortunately, it makes the calendar factory crash. This patch adapts to more recent changes, like the addition of EEwsAttachmentInfo, where I also added prefer_filename property, which is useful in calendar.

The runtime warning from above is a typo in e_ews_connection_attach_file(), which used the original 'uri' in call of g_file_get_contents(), instead of converted 'filepath'.
Comment 5 Milan Crha 2013-07-29 10:58:37 UTC
I forgot to add, the patch also fixes unneeded attachment removals - there could be dropped all attachments on save of the event.
Comment 6 Milan Crha 2013-07-29 11:10:18 UTC
Created commit 0dfaeb4 in ews master (3.9.90+)