After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660692 - Unbreak build when some locale macros are not defined.
Unbreak build when some locale macros are not defined.
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
git master
Other OpenBSD
: Normal major
: ---
Assigned To: Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-02 13:22 UTC by Antoine Jacoutot
Modified: 2011-10-03 11:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check for locale macros availability before use (1.74 KB, patch)
2011-10-02 13:22 UTC, Antoine Jacoutot 		none Details | Review

Description Antoine Jacoutot 2011-10-02 13:22:59 UTC 
Created attachment 198005 [details] [review]
check for locale macros availability before use

Hi.

LC_PAPER and LC_MEASUREMENT are not posix and may not be defined on all
systems (they aren't on OpenBSD).
Only use setlocale(2) with these macros if they are actually defined.

ok to push?
Comment 1 Bastien Nocera 2011-10-03 11:29:37 UTC 
In the future please use one bug per panel.

I fixed the bug in the printers panel:

commit 4e6c27851419f32eebc72ccb92dae924c582a7d9
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Oct 3 12:26:08 2011 +0100

    printers: Fix build on systems without LC_PAPER
    
    By using gtk_paper_size_get_default() directly to do all
    the hard work for us.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=660692

For the region panel, please file a separate bug, and make it so that the measurement display is removed from the panel when LC_MEASUREMENT isn't available, as I don't think we want to see an empty label there.
Comment 2 Antoine Jacoutot 2011-10-03 11:48:00 UTC 
(In reply to comment #1)
> In the future please use one bug per panel.

Truly sorry about that, I wasn't aware this was the way to go.

> For the region panel, please file a separate bug, and make it so that the
> measurement display is removed from the panel when LC_MEASUREMENT isn't
> available, as I don't think we want to see an empty label there.

Well I kept the display on purpose because the Currency label is also empty here, so I wanted to be consistent. Same thing with the System tab and "system settings", all labels are empty there.

Anyway, I'll open a new bug.