After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660653 - Port the new trie implementation from Tomboy
Port the new trie implementation from Tomboy
Status: RESOLVED FIXED
Product: gnote
Classification: Applications
Component: main
git master
Other Linux
: Normal normal
: ---
Assigned To: gnote-maint
gnote-maint
: 589121 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-01 21:20 UTC by Debarshi Ray
Modified: 2011-10-04 18:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port the new trie implementation from Tomboy (19.65 KB, patch)
2011-10-01 21:25 UTC, Debarshi Ray 		none Details | Review
Port the new trie implementation from Tomboy (20.03 KB, patch)
2011-10-02 19:45 UTC, Aurimas Černius 		none Details | Review

Description Debarshi Ray 2011-10-01 21:20:09 UTC 
Tomboy recently updated its trie implementation: https://bugzilla.gnome.org/584362
Comment 1 Debarshi Ray 2011-10-01 21:25:08 UTC 
Created attachment 197983 [details] [review]
Port the new trie implementation from Tomboy
Comment 2 Aurimas Černius 2011-10-02 19:45:26 UTC 
Created attachment 198038 [details] [review]
Port the new trie implementation from Tomboy

One additional line added to the fix, to compile with most recent version of Gnote.
Comment 3 Aurimas Černius 2011-10-03 20:08:01 UTC 
The performance is excellent, great job!
I'll run it for some time on my machine, to see if nothing is broken, but I'm quite confident with it already.
Comment 4 Aurimas Černius 2011-10-03 20:11:13 UTC 
*** Bug 589121 has been marked as a duplicate of this bug. ***
Comment 5 Dan Williams 2011-10-04 16:37:19 UTC 
I've been running it for a few days so far on my machine (1200 notes) and haven't observed any regressions, though I don't do much with it other than adding new notes and searching for text in existing ones.  I don't do a lot of deletion.  But it's a lot faster for me, great work!
Comment 6 Aurimas Černius 2011-10-04 18:48:29 UTC 
I see Debarshi pushed this to git. Closing.
Will be available in 0.8.1.