After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660626 - unbreak build if LC_PAPER is not defined
unbreak build if LC_PAPER is not defined
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: printers
3.2.x
Other OpenBSD
: Normal major
: ---
Assigned To: Marek Kašík
gnome-settings-daemon-maint
: 661090 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-01 12:06 UTC by Antoine Jacoutot
Modified: 2011-10-07 21:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't use LC_PAPER is we don't define this macro (916 bytes, patch)
2011-10-01 12:06 UTC, Antoine Jacoutot 		none Details | Review

Description Antoine Jacoutot 2011-10-01 12:06:09 UTC 
Created attachment 197958 [details] [review]
don't use LC_PAPER is we don't define this macro

Hi.

LC_PAPER is not posix and may not be defined on all systems (it's not on OpenBSD).
This patch only use setlocale(2) LC_PAPER is this macro actually exist.

ok to push?
Comment 1 Matthias Clasen 2011-10-01 13:54:24 UTC 
Shouldn't this just use gtk_paper_size_get_default() ?

Or, if you don't want to link against that, how about copying the function entirely, instead of just this one part ?

But for a minimal fix, this patch looks good.
Comment 2 Bastien Nocera 2011-10-03 10:31:43 UTC 
Filed https://bugzilla.gnome.org/show_bug.cgi?id=660769 about the lack of support for non-A4/non-Letter paper sizes.

Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Oct 3 11:28:28 2011 +0100

    printers: Fix build on systems without LC_PAPER
    
    By using gtk_paper_size_get_default() directly to do all
    the hard work for us.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=660626
Comment 3 Bastien Nocera 2011-10-07 21:04:54 UTC 
*** Bug 661090 has been marked as a duplicate of this bug. ***