After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660600 - Use '' for non-translated strings
Use '' for non-translated strings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-30 22:01 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-10-04 20:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Add a missed translation (1012 bytes, patch)
2011-09-30 22:01 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
Use '' for non-translated strings (7.22 KB, patch)
2011-09-30 22:01 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-09-30 22:01:28 UTC 
Dug through the source code with grep -PR '(?<!\()".*"' and found all non-translated
strings. Didn't touch js/ui/scripting.js or the perf stuff -- I'll let Owen touch that one.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-09-30 22:01:30 UTC 
Created attachment 197921 [details] [review]
keyboard: Add a missed translation

The word "tray" should be translated to other languages.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-09-30 22:01:34 UTC 
Created attachment 197922 [details] [review]
Use '' for non-translated strings

Pay attention to the style guidelines.
Comment 3 drago01 2011-10-01 07:17:37 UTC 
Review of attachment 197921 [details] [review]:

Fine but you are adding a string hence -> 3.4.
Comment 4 drago01 2011-10-01 07:18:23 UTC 
Review of attachment 197922 [details] [review]:

Looks good.
Comment 5 Frederic Peters 2011-10-01 10:43:36 UTC 
(In reply to comment #3)
> Review of attachment 197921 [details] [review]:
> 
> Fine but you are adding a string hence -> 3.4.

This doesn't add a string but mark an existing string as translatable, this is not subject to string freeze.
Comment 6 Jasper St. Pierre (not reading bugmail) 2011-10-01 18:39:50 UTC 
Wait, I thought we were past string freeze now? I've certainly added new strings:

  http://git.gnome.org/browse/gnome-shell/commit/?id=1e6b824ede91676ce14b243d02e988e52a937684
Comment 7 Frederic Peters 2011-10-02 14:29:50 UTC 
Hard code freeze is lifted after .0 but other freezes remain in effect for the stable branch.

I sent a notice about the other commit.
Comment 8 Jasper St. Pierre (not reading bugmail) 2011-10-04 20:50:12 UTC 
Attachment 197921 [details] pushed as 4e11410 - keyboard: Add a missed translation
Attachment 197922 [details] pushed as f13f5bc - Use '' for non-translated strings


I'm pushing these assuming that it won't break string freeze.