After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660538 - ETable headers beautifications
ETable headers beautifications
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Shell
unspecified
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-09-30 05:15 UTC by Cosimo Cecchi
Modified: 2011-09-30 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ETableHeader: rework the header button drawing code for GTK+ 3 (16.22 KB, patch)
2011-09-30 05:15 UTC, Cosimo Cecchi 		none Details | Review
ETableHeader: nuke unused code (4.89 KB, patch)
2011-09-30 05:15 UTC, Cosimo Cecchi 		none Details | Review
improved table headers goodness (27.52 KB, image/png)
2011-09-30 05:19 UTC, Cosimo Cecchi 		  Details
ETableHeader: rework the header button drawing code for GTK+ 3 (16.32 KB, patch)
2011-09-30 05:45 UTC, Cosimo Cecchi 		none Details | Review

Description Cosimo Cecchi 2011-09-30 05:15:22 UTC 
ETable headers don't look as good as GtkTreeView headers; as the ETable draw implementation uses deprecated methods to draw the buttons, themes can't easily customize it.
Port the drawing code to GtkStyleContext, which also has the nice side effect of making everything more streamlined.
Comment 1 Cosimo Cecchi 2011-09-30 05:15:24 UTC 
Created attachment 197844 [details] [review]
ETableHeader: rework the header button drawing code for GTK+ 3

The code in ETable that draws the button headers is outdated, and uses
deprecated gtk_paint_* functions mixed with cairo.
Port the code to use the GtkStyleContext API, which allows themes to
give the header the same appearance of a regular GtkTreeView header.
Comment 2 Cosimo Cecchi 2011-09-30 05:15:27 UTC 
Created attachment 197845 [details] [review]
ETableHeader: nuke unused code
Comment 3 Cosimo Cecchi 2011-09-30 05:19:48 UTC 
Created attachment 197847 [details]
improved table headers goodness
Comment 4 Cosimo Cecchi 2011-09-30 05:45:08 UTC 
Created attachment 197848 [details] [review]
ETableHeader: rework the header button drawing code for GTK+ 3

Right patch this time.
Comment 5 Matthew Barnes 2011-09-30 15:58:47 UTC 
Awesome, thanks for this!  Always happy to nuke ETable code...

Committed both patches for 3.3.1:

http://git.gnome.org/browse/evolution/commit/?id=b73a8f243ea4446f39012d7a64c107c25ff6d854

http://git.gnome.org/browse/evolution/commit/?id=4674fb54872a093b9e116de91e7122c42be735fa