After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660496 - Remove GLIC-specific function call
Remove GLIC-specific function call
Status: RESOLVED FIXED
Product: glom
Classification: Other
Component: build
1.19.x
Other OpenBSD
: Normal normal
: ---
Assigned To: Murray Cumming
Murray Cumming
Depends on:
Blocks:
 
 
Reported: 2011-09-29 16:41 UTC by Jasper Lievisse Adriaanse
Modified: 2011-10-16 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't call __libc_freeres which is GLIBC-only. (1.07 KB, patch)
2011-09-29 16:41 UTC, Jasper Lievisse Adriaanse 		committed Details | Review
Hide another __libc_freeres call (1.46 KB, patch)
2011-10-15 07:35 UTC, Jasper Lievisse Adriaanse 		committed Details | Review

Description Jasper Lievisse Adriaanse 2011-09-29 16:41:48 UTC 
Created attachment 197782 [details] [review]
Don't call __libc_freeres which is GLIBC-only.

__libc_freeres() appears to only exist in GLIBC, attached diff adjusts the code in glom/main.cc to thus only call it on Linux. Ok to push the attached patch?
Comment 1 Murray Cumming 2011-09-29 20:44:37 UTC 
Sure. Please do, with a ChangeLog entry. Thanks.
Comment 2 Jasper Lievisse Adriaanse 2011-09-29 20:56:35 UTC 
All done. Thanks.
Comment 3 Jasper Lievisse Adriaanse 2011-10-15 07:34:41 UTC 
Here's another one. Allright?
Comment 4 Jasper Lievisse Adriaanse 2011-10-15 07:35:09 UTC 
Created attachment 199053 [details] [review]
Hide another __libc_freeres call
Comment 5 Jasper Lievisse Adriaanse 2011-10-15 07:35:51 UTC 
Review of attachment 197782 [details] [review]:

This was committed as bf111b2f3d39fa8aa27a6b3e6778ae8f987cad8f
Comment 6 Murray Cumming 2011-10-15 19:41:19 UTC 
Thanks.
Comment 7 Murray Cumming 2011-10-15 19:41:56 UTC 
Oh, I mean, please push it. I thought you had already.
Comment 8 Jasper Lievisse Adriaanse 2011-10-16 17:51:17 UTC 
Now I have :-)
Comment 9 Jasper Lievisse Adriaanse 2011-10-16 17:51:34 UTC 
Review of attachment 199053 [details] [review]:

Committed as af9f209eab099458cc4d92c9170757c78b11b1b1