After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660494 - lookingGlass: Show extension state in gnome-shell
lookingGlass: Show extension state in gnome-shell
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-29 16:36 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-09-30 08:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lookingGlass: Show extension state in gnome-shell (2.39 KB, patch)
2011-09-29 16:36 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-09-29 16:36:18 UTC 
Reported on reddit (via PMs):

"It doesn't help at all that everything in LookingGlass makes one believe that those "not enabled" extensions are actually loaded and activated (yes, I will file a bug)."
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-09-29 16:36:20 UTC 
Created attachment 197781 [details] [review]
lookingGlass: Show extension state in gnome-shell

We translate and create an actor to show the extension state, but we never
actually add it anywhere. Fix that.
Comment 2 Colin Walters 2011-09-29 16:44:57 UTC 
Review of attachment 197781 [details] [review]:

I don't understand why this patch is removing the separate actionsContainer when we could just call metaBox.add(state) and be done.  Right?
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-09-29 17:15:45 UTC 
Attachment 197781 [details] pushed as 32dc24c - lookingGlass: Show extension state in gnome-shell
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-09-29 17:18:10 UTC 
Pushed after minor IRC review:

<magcius> walters, that will have inappropriate spacing: it will look like "EnabledView Source Web Page"
<magcius> I just found it cleaner to use one container than three.
<walters> magcius, okay
<magcius> I should probably add an "align: St.Align.END", though
<magcius> but making too many UI changes to the looking glass is hard
<magcius> can we have a looking glass looking glass?

--

<magcius> walters, so the LG patch is ACN?
<walters> yes