After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660409 - Fails to run without gnome-shell installed
Fails to run without gnome-shell installed
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.2.x
Other Linux
: Normal major
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-29 01:18 UTC by Balló György
Modified: 2011-09-30 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Check for gnome-shell before running gdm-shell session (562 bytes, patch)
2011-09-29 01:18 UTC, Balló György
accepted-commit_now Details | Review
data: add back check for gnome-shell before running gdm-shell session (976 bytes, patch)
2011-09-29 02:41 UTC, Balló György
committed Details | Review

Description Balló György 2011-09-29 01:18:31 UTC
Created attachment 197720 [details] [review]
Check for gnome-shell before running gdm-shell session

When GDM starts, it only checks that hardware acceleration available or not. After that GDM trying to execute gnome-shell even if not installed instead of fall back to metacity. In this case the user gets a blank screen without a greeter, and can't do anything.

Checking for GDM was added in this commit:
http://git.gnome.org/browse/gdm/commit/data/gdm-shell.session.in?id=4892c9447324f2248ce944f150abe3143f78eaa3

But unfortunately, it was completely removed in this commit:
http://git.gnome.org/browse/gdm/commit/data/gdm-shell.session.in?id=f350f58c78551614d8c864921705f26aa2fffa18

I highly recommend to add back the original check to ensure that gnome-shell is installed before trying to run them.
Comment 1 Ray Strode [halfline] 2011-09-29 01:43:57 UTC
Review of attachment 197720 [details] [review]:

makes sense. Make sure you reference this bug and give a small description on why your making the change in your commit message.
Comment 2 Balló György 2011-09-29 02:41:05 UTC
Created attachment 197721 [details] [review]
data: add back check for gnome-shell before running gdm-shell session

I added a better formatted patch.
Comment 3 Ray Strode [halfline] 2011-09-30 21:49:40 UTC
Thanks.