After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660310 - windowAttentionHandler: Remove "%s has finished starting"
windowAttentionHandler: Remove "%s has finished starting"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-28 01:07 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-09-29 14:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
windowAttentionHandler: Refactor startup-sequence handling (1.43 KB, patch)
2011-09-28 01:07 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
windowAttentionHandler: Remove "%s has finished starting" (1.23 KB, patch)
2011-09-28 01:07 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
windowAttentionHandler: Remove "%s has finished starting" (1.98 KB, patch)
2011-09-28 03:24 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
windowAttentionHandler: Remove "%s has finished starting" (2.59 KB, patch)
2011-09-28 03:40 UTC, Jasper St. Pierre (not reading bugmail) 		accepted-commit_now Details | Review
windowAttentionHandler: Remove "%s has finished starting" (3.03 KB, patch)
2011-09-28 19:52 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
windowAttentionHandler: Remove "%s has finished starting" (3.03 KB, patch)
2011-09-29 12:30 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-09-28 01:07:20 UTC 
Spotted on http://www.reddit.com/r/linux/comments/ktay3/thanks_for_precision/

It's quite a silly message anyway.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-09-28 01:07:23 UTC 
Created attachment 197621 [details] [review]
windowAttentionHandler: Refactor startup-sequence handling

Instead of wiping and remaking an entire hash of startup IDs every time, just
modify the entry that's necessary.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-09-28 01:07:28 UTC 
Created attachment 197622 [details] [review]
windowAttentionHandler: Remove "%s has finished starting"

The message is verbose and confusing. Use the traditional "'%s' is ready"
for all cases.
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-09-28 03:24:08 UTC 
Created attachment 197625 [details] [review]
windowAttentionHandler: Remove "%s has finished starting"

The message is verbose and confusing. Use the traditional "'%s' is ready"
for all cases.



--

remove now unused _getTitle and _getBanner funcs.
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-09-28 03:40:50 UTC 
Created attachment 197626 [details] [review]
windowAttentionHandler: Remove "%s has finished starting"

The message is verbose and confusing. Use the traditional "'%s' is ready"
for all cases.



Gah, I'm just terrible tonight. If we don't need to do anything with the
startup IDs, why track them?
Comment 5 drago01 2011-09-28 17:48:18 UTC 
Review of attachment 197626 [details] [review]:

Fine.
Comment 6 Jasper St. Pierre (not reading bugmail) 2011-09-28 19:52:13 UTC 
Created attachment 197700 [details] [review]
windowAttentionHandler: Remove "%s has finished starting"

The message is verbose and confusing. Use the traditional "'%s' is ready"
for all cases.



--

The old one was broken. This better?
Comment 7 drago01 2011-09-29 06:53:05 UTC 
Review of attachment 197700 [details] [review]:

::: js/ui/windowAttentionHandler.js
@@ +41,3 @@
+        source.signalIDs.push(window.connect('notify::title',
+                                             Lang.bind(this, function(win) {
+                                                 notification.update(title, banned);

Who's banned? ;)
Comment 8 Jasper St. Pierre (not reading bugmail) 2011-09-29 12:30:54 UTC 
Created attachment 197759 [details] [review]
windowAttentionHandler: Remove "%s has finished starting"

The message is verbose and confusing. Use the traditional "'%s' is ready"
for all cases.



err, yeah. This is why we have code review.
Comment 9 drago01 2011-09-29 13:05:26 UTC 
Review of attachment 197759 [details] [review]:

Looks good, just one minor nitpick.

::: js/ui/windowAttentionHandler.js
@@ +40,3 @@
 
+        source.signalIDs.push(window.connect('notify::title',
+                                             Lang.bind(this, function(win) {

This param is no longer being used so you can just remove it.
Comment 10 Jasper St. Pierre (not reading bugmail) 2011-09-29 14:00:32 UTC 
Attachment 197759 [details] pushed as 6510904 - windowAttentionHandler: Remove "%s has finished starting"