After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660277 - nautilus crashed with SIGSEGV in gtk_icon_info_load_symbolic_for_context()
nautilus crashed with SIGSEGV in gtk_icon_info_load_symbolic_for_context()
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Crashers
3.2.x
Other Linux
: Normal critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-27 18:32 UTC by Pedro Villavicencio
Modified: 2011-09-28 18:22 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2


Attachments
places-sidebar: don't crash when not finding the eject symbolic icon (2.22 KB, patch)
2011-09-28 18:22 UTC, Cosimo Cecchi
committed Details | Review

Description Pedro Villavicencio 2011-09-27 18:32:10 UTC
this report has been filed here:

https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/860659

the reporter updated the machine to the new version of nautilus and got this crash afterwards , backtrace:

.

Thread 1 (Thread 0xb783e850 (LWP 5956))

  • #0 gtk_icon_info_load_symbolic_for_context
    at /build/buildd/gtk+3.0-3.2.0/./gtk/gtkicontheme.c line 3345
  • #1 get_eject_icon
    at nautilus-places-sidebar.c line 243
  • #2 add_place
    at nautilus-places-sidebar.c line 375
  • #3 update_places
    at nautilus-places-sidebar.c line 499
  • #4 nautilus_places_sidebar_set_parent_window
    at nautilus-places-sidebar.c line 3379
  • #5 nautilus_places_sidebar_new
    at nautilus-places-sidebar.c line 3399
  • #6 nautilus_window_set_up_sidebar
    at nautilus-window.c line 459
  • #7 nautilus_window_show_sidebar
    at nautilus-window.c line 508
  • #8 nautilus_window_show
    at nautilus-window.c line 1652
  • #9 g_closure_ref
    at /build/buildd/glib2.0-2.30.0/./gobject/gclosure.c line 536
  • #10 g_binding_get_target_property
    at /build/buildd/glib2.0-2.30.0/./gobject/gbinding.c line 766
  • #11 g_dbus_object_manager_server_set_property
    at /build/buildd/glib2.0-2.30.0/./gio/gdbusobjectmanagerserver.c line 160
  • #12 g_hash_table_lookup_node
    at /build/buildd/glib2.0-2.30.0/./glib/ghash.c line 381
  • #13 g_hash_table_lookup
    at /build/buildd/glib2.0-2.30.0/./glib/ghash.c line 1022
  • #14 g_flags_register_static
    at /build/buildd/glib2.0-2.30.0/./gobject/genums.c line 231
  • #15 ??
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
Comment 1 Cosimo Cecchi 2011-09-28 18:22:52 UTC
The following fix has been pushed:
82a39de places-sidebar: don't crash when not finding the eject symbolic icon


The underlying problem here is your icon theme doesn't have a media-eject-symbolic icon, but we shouldn't crash in this case. I pushed a fix for the crash to git master.
Comment 2 Cosimo Cecchi 2011-09-28 18:22:57 UTC
Created attachment 197691 [details] [review]
places-sidebar: don't crash when not finding the eject symbolic icon

If a theme doesn't have media-eject-symbolic, icon_info can be NULL, and
we would crash trying to load a pixbuf from it anyway.
Fix this and show the stock 'missing image' pixbuf when the theme
doesn't have the specified icons.