After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660271 - menus don't have borders
menus don't have borders
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Fallback Mode
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
: 664071 664179 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-27 18:01 UTC by William Jon McCann
Modified: 2012-11-12 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (22.01 KB, image/png)
2011-09-27 18:01 UTC, William Jon McCann
Details
Screenshot showing a GTK2 menu without borders (52.30 KB, image/png)
2012-10-05 11:43 UTC, Marcus Moeller
Details
dotted top menu border (90.51 KB, image/png)
2012-11-03 19:01 UTC, Marcus Moeller
Details

Description William Jon McCann 2011-09-27 18:01:33 UTC
Created attachment 197592 [details]
screenshot

The panel menus don't have borders and this makes them blend in to the underlying windows.
Comment 1 Cosimo Cecchi 2011-09-28 16:40:54 UTC
This is tricky to fix; the theme doesn't define any border for menus on purpose, as in non-fallback mode mutter draws a shadow around the menu.
Should we find a way to use a theme variation in fallback mode?
Comment 2 Cosimo Cecchi 2011-11-14 21:25:35 UTC
*** Bug 664071 has been marked as a duplicate of this bug. ***
Comment 3 Cosimo Cecchi 2011-11-17 12:33:07 UTC
*** Bug 664179 has been marked as a duplicate of this bug. ***
Comment 4 Marcus Moeller 2011-11-17 13:02:06 UTC
Please note that this does not only affects fallback mode, but also GTK 3 applications on other Window Managers (like Xfce ...)
Comment 5 Marcus Moeller 2011-11-17 15:07:05 UTC
The strange thing is that this worked correctly in 3.0.2
Comment 6 Cosimo Cecchi 2011-11-17 15:18:20 UTC
(In reply to comment #5)
> The strange thing is that this worked correctly in 3.0.2

Yes, it was changed for 3.2.
Comment 7 Andrea Bolognani 2011-12-12 15:12:44 UTC
For what it’s worth, I think the new menus look worse even inside GNOME Shell, with shadows and everything. They were perfectly fine in 3.0.x.

What was the rationale for changing this?
Comment 8 Andrea Bolognani 2012-03-16 19:36:59 UTC
Can we have some feedback from designers?

I really hope to get this reverted in time for 3.4.
Comment 9 Marcus Moeller 2012-05-08 14:29:50 UTC
So as 3.4 is now released, do we have any update on that?
Comment 10 Jean-François Fortin Tam 2012-06-28 20:46:04 UTC
I had filed this in bug #662951; you might find some more information there.
Comment 11 Marcus Moeller 2012-06-28 21:18:41 UTC
I think this one is a different bug. I was talking about the black border around drop down menus (not shadows). These are shown correctly in GNOME Shell but not in non-gnome Desktop Environments or Fallback Mode.
Comment 12 Andrea Bolognani 2012-06-28 22:09:31 UTC
According to bug #649374, which is referenced by bug #662951, the rationale was reducing the "in your face" effect. Fair enough.

Removing completely the border around the menus, as opposed to reducing the drop shadow while leaving a 1px gray border around them, seems to go too far in that direction.

Not only in fallback mode it is *absolutely impossible* to see how big the menu is if the application's window is mostly white (eg. gnome-terminal or nautilus), it also looks much worse and it strains the eyes much more in standard mode, because the contrast between the active menu item and the rest of the menu bar is too low.

Please consider adding a thin gray border around menus (and menu items), 1px would be enough.
Comment 13 Sam Morris 2012-08-21 11:31:36 UTC
#include <plea_for_reversion_for_3.56>

In the mean time, here is a workaround:

$ cat ~/.config/gtk-3.0/gtk.css 
.menu {
	border-style: solid;
	border: 1px solid @menu_separator;
}
Comment 14 Andrea Bolognani 2012-08-21 15:21:15 UTC
Better yet:

$ cat ~/.config/gtk-3.0/gtk.css
.menu {
    border: 1px solid @menu_separator;
}
.menuitem {
    border: 1px solid @menu_separator;
    border-bottom: 0;
}

And this is still not enough, IMHO.
Being subtle is OK, but there has to be some contrast or eye strain becomes unavoidable.
Comment 15 Marcus Moeller 2012-09-08 09:07:47 UTC
Does not change anything, here. Do I have to include the css in settings.ini?
Comment 16 Andrea Bolognani 2012-09-09 20:31:45 UTC
Have you restarted the relevant application?

I just had to create the relevant file, drop the tweaked CSS in there and restart the application to see the changes.
Comment 17 Marcus Moeller 2012-09-19 13:39:11 UTC
In the past the gtk-2.0 component of the Adwaita theme has been clearlooks. This has been changed recently. The gtk-2.0 has been reworked to mimic the gtk-3.0 Adwaita look and feel.

The above 'hint' only seems to apply to gtk-3.0 apps only. So do you have a hint how to make this work with gtk-2.0 apps, too?
Comment 18 Marcus Moeller 2012-10-05 11:30:53 UTC
@Cosimo Cecchi this bug is now known for quite a long time and it is affecting more and more users, even more with the addition of the GTK2 theme.

Is there any chance to get it fixed? If it's not possible with the Adwaita engine, we could for example use the clearlooks engine for the menus, which got a proper border setting.

Please note, this is not only related to fallback mode, but to everyone who is using GNOME Apps in a non-GNOME environment with the default theme enabled.
Comment 19 Marcus Moeller 2012-10-05 11:43:32 UTC
Created attachment 225873 [details]
Screenshot showing a GTK2 menu without borders
Comment 20 Cosimo Cecchi 2012-10-08 16:41:13 UTC
This is now fixed in master - See [1] for details

[1] http://git.gnome.org/browse/gnome-themes-standard/commit/?id=9c62ba404fa8a76d1c56cce4f066e94ccc637900
Comment 21 Marcus Moeller 2012-10-18 07:00:59 UTC
I have tested the patch, and it works in general.

From design point of view I guess you have decided that it would look better if pull down menus won't have a top border (which was the case e.g. with Clearlooks).

This results in pop-up/right click context menus to not show top-borders (see screenshot). I am not sure if there is a way to distinguish between menus that are opened from a menu item and general menus (like popup menus or right-click context menus). If so, please add top borders to the latter.

If that's not possible, I would like to suggest to add top borders in general.
Comment 22 Cosimo Cecchi 2012-10-18 14:50:40 UTC
(In reply to comment #21)

> This results in pop-up/right click context menus to not show top-borders (see
> screenshot). I am not sure if there is a way to distinguish between menus that
> are opened from a menu item and general menus (like popup menus or right-click
> context menus). If so, please add top borders to the latter.
> 
> If that's not possible, I would like to suggest to add top borders in general.

There's a way to distinguish between these two cases in GTK3 (and the fallback menu border style actually takes it into account and draws a top border for unattached menus in this case), but not for GTK2 unfortunately.

I don't think it would look really nice to have top borders rendered for menus attached to the menubar, but I'll try to play with it and see if we can improve things a bit.
Comment 23 Marcus Moeller 2012-11-03 18:37:59 UTC
Have you found a way to improve the look of the top border?

In GTK3 a very light top border is drawn e.g. to context menus. I would just suggest to add this light border to GTK2 menus in general. It should not have a noticable impact on the overall look of Menubar menus.
Comment 24 Marcus Moeller 2012-11-03 19:01:34 UTC
Created attachment 227978 [details]
dotted top menu border

I have noticed that the top menu border is a very light dotted line, already. It could be improved by replacing the dotted line with a full line which is slightly darker.