After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660250 - FTBFS with -Werror=format-security
FTBFS with -Werror=format-security
Status: RESOLVED OBSOLETE
Product: gimp-gap
Classification: Other
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: hof
hof
Depends on:
Blocks:
 
 
Reported: 2011-09-27 14:57 UTC by Thibaut Paumard
Modified: 2018-05-24 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
printf(msg) -> printf("%s", msg) (4.55 KB, patch)
2011-09-27 14:57 UTC, Thibaut Paumard 		none Details | Review

Description Thibaut Paumard 2011-09-27 14:57:38 UTC 
Created attachment 197574 [details] [review]
printf(msg) -> printf("%s", msg)

Hi,

I am the Debian maintainer for gimp-gap (2.6.0).

Several Linux distribution (including Debian) are starting to compile everything with -Werror=format-security by default. This C flag helps catching security issues with printf().

This causes gimp-gap building to fail (on purpose) on calls such as "printf(msg)" (actually, most calls look like "g_message(msg)").

I have prepared a patch where all these calls are changed to "printf("%s", msg)", which is safer and passes the compiler tests.

Best regards, Thibaut.
Comment 1 André Klapper 2012-02-02 21:18:11 UTC 
Comment on attachment 197574 [details] [review]
printf(msg) -> printf("%s", msg)

[Setting "patch" flag and correcting mime type so this can actually be queried for.]
Comment 2 hof 2012-02-03 07:56:58 UTC 
Your patch was already applied, but to git main latest
see commit 2431bd4f33e9654de29e5fbf27b45893b37971c0

The GAP_2_6_0 branch was not updated since 2 years.
All fixes and new features were done in GIT master.

GIT master is still backwards compatible to GIMP-2.6.x
Probably there will be one more stable GIMP-GAP-2.6.x release where
the main latest development will be merged into the 2.6 stable branch.
This may happen whe i start GIMP_GAP port to GIMP-2.8
(e.g. not before GIMP-2.8 is available)
Comment 3 GNOME Infrastructure Team 2018-05-24 10:22:41 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp-gap/issues/14.