After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660164 - Color correction applied on the wrong display
Color correction applied on the wrong display
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: color
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-26 18:43 UTC by Cosimo Cecchi
Modified: 2012-02-01 11:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test patch (4.00 KB, patch)
2011-09-27 17:21 UTC, Richard Hughes
none Details | Review

Description Cosimo Cecchi 2011-09-26 18:43:30 UTC
- Setup: external display (no color correction) and laptop display (color corrected).
- Open gnome-c-c, go to Display
- Disable the laptop display
- Enable the laptop display again
- Color correction is applied *also* to the external display, even though the device has no profiles at all associated with it in the panel. Actually, there's really no way of disabling it, since the device still appears without any profile or correction. I can "feel" the color correction, though, as the profile for my laptop display looks *ugly* on the external monitor :)

Fun things to try at this point:
- if you disable and re-enable the laptop display again, it looks like the external display finally loses the stray color correction
- if you do it one more time, the bug will kick in again
- these two states will alternate each time you disable and re-enable the laptop display
Comment 1 Richard Hughes 2011-09-27 17:21:36 UTC
Created attachment 197587 [details] [review]
test patch

Can you try this test patch please. It seems to fix the issue for me. Thanks!
Comment 2 Cosimo Cecchi 2011-10-03 13:57:39 UTC
This solves the bug for me, though when using gnome-settings-daemon with the patch I see these warnings on the terminal when turning off the laptop display:

(gnome-settings-daemon:26929): GnomeDesktop-CRITICAL **: gnome_rr_crtc_get_gamma: assertion `crtc != NULL' failed

(gnome-settings-daemon:26929): color-plugin-WARNING **: failed to set xrandr-Lenovo Group Limited gamma tables: no data in the CLUT array
Comment 3 Richard Hughes 2011-10-03 14:10:40 UTC
(In reply to comment #2)
> This solves the bug for me, though when using gnome-settings-daemon with the
> patch I see these warnings on the terminal when turning off the laptop display:

Ahh, good catch, thanks.

commit 6810be19369870bab4eb44780c742b6d078e5e97
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Oct 3 15:09:15 2011 +0100

    color: Fix critical warning if the user disables the internal LCD screen
    
    Note: this fix also applies to any output we've disabled but left connected.
Comment 4 Richard Hughes 2011-10-03 14:27:57 UTC
I've pushed both patches to g-s-d master, so could you please test that and tell me how you get on. Thanks!
Comment 5 Cosimo Cecchi 2011-10-03 14:39:25 UTC
(In reply to comment #4)
> I've pushed both patches to g-s-d master, so could you please test that and
> tell me how you get on. Thanks!

I still see

"(gnome-settings-daemon:15142): color-plugin-WARNING **: failed to set xrandr-Lenovo Group Limited gamma tables: gamma size is zero"

but it appears to work fine.