After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660151 - check x11 backend in runtime
check x11 backend in runtime
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-26 15:51 UTC by Young-Ho Cha
Modified: 2011-10-28 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
check x11 backend in runtime (446 bytes, patch)
2011-09-26 15:51 UTC, Young-Ho Cha 		needs-work Details | Review
check x11 backend in runtime (409 bytes, patch)
2011-09-27 16:03 UTC, Young-Ho Cha 		accepted-commit_now Details | Review

Description Young-Ho Cha 2011-09-26 15:51:14 UTC 
Created attachment 197492 [details] [review]
check x11 backend in runtime

gtk 3.x can build with multiple gdk backends, and it can be set in runtime.

So vte must check gdk backend in runtime, too.
Comment 1 Christian Persch 2011-09-26 17:24:20 UTC 
vte isn't usable on anything non-unix, so I don't see what the point of this patch would be?
Comment 2 Behdad Esfahbod 2011-09-26 17:35:34 UTC 
Well there's gtk-wayland backend...
Comment 3 Young-Ho Cha 2011-09-26 22:35:21 UTC 
And there's gtk-broadway backend, too.
Comment 4 Christian Persch 2011-09-27 10:33:37 UTC 
Alright then.

+#if GTK_CHECK_VERSION (2, 91, 6)
+            if (GDK_IS_X11_DISPLAY(gdk_display_get_default()))
+#endif

Lose the version check; vte 0.30 only supports gtk3.
Also, don't use the default display, use the display of the GdkScreen passed into this function.
Comment 5 Young-Ho Cha 2011-09-27 16:03:20 UTC 
Created attachment 197580 [details] [review]
check x11 backend in runtime

update patch as comment #4
Comment 6 Christian Persch 2011-09-27 16:06:25 UTC 
Comment on attachment 197580 [details] [review]
check x11 backend in runtime

Commit to the vte-0-30 branch only.
Comment 7 Christian Persch 2011-10-28 12:11:11 UTC 
Committed to vte-0-32 branch. In future, please always attach patches in git format-patch format.