After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660129 - frames: Don't try to show resize handles below buttons
frames: Don't try to show resize handles below buttons
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-26 13:05 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-10-21 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
frames: Don't try to show resize handles below buttons (4.79 KB, patch)
2011-09-26 13:05 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
frames: Don't try to show resize handles below buttons (4.79 KB, patch)
2011-09-26 14:10 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
frames: Disable the titlebar "inner resize" (3.39 KB, patch)
2011-10-05 00:01 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-09-26 13:05:50 UTC 
Found while testing visible borders. It just feels "wrong" to have the resize
handles directly under buttons like it currently is.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-09-26 13:05:51 UTC 
Created attachment 197473 [details] [review]
frames: Don't try to show resize handles below buttons

The space between the bottom of frame buttons and the top of the client window
is the titlebar's padding and has the same rules as any other control. It shouldn't.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-09-26 14:10:18 UTC 
Created attachment 197479 [details] [review]
frames: Don't try to show resize handles below buttons

The space between the bottom of frame buttons and the top of the client window
is the titlebar's padding and has the same rules as any other control. It shouldn't.



I completely forgot about get_texture().
Comment 3 Florian Müllner 2011-10-04 22:06:43 UTC 
Review of attachment 197479 [details] [review]:

The code looks like a gross hack to me. I agree that showing resize handles for the titlebar padding is wrong, but in my opinion it's equally wrong without buttons (e.g. on the left using the default layout).
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-10-04 22:19:52 UTC 
(In reply to comment #3)
> Review of attachment 197479 [details] [review]:
> 
> The code looks like a gross hack to me. I agree that showing resize handles for
> the titlebar padding is wrong, but in my opinion it's equally wrong without
> buttons (e.g. on the left using the default layout).

OK -- should we remove all of the "inside resize" stuff and go fully to invisible borders?
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-10-04 22:20:34 UTC 
(In reply to comment #4)
> OK -- should we remove all of the "inside resize" stuff and go fully to
> invisible borders?

er, to borders in general, just not on the titlebar area
Comment 6 Florian Müllner 2011-10-04 22:28:19 UTC 
(In reply to comment #4)
> OK -- should we remove all of the "inside resize" stuff and go fully to
> invisible borders?

Sounds like a plan to me (maybe it's just me, but I don't think the "inside resize" stuff worked great to begin with ...)
Comment 7 Jasper St. Pierre (not reading bugmail) 2011-10-05 00:01:56 UTC 
Created attachment 198280 [details] [review]
frames: Disable the titlebar "inner resize"

Since invisible draggable borders have been around, there isn't really a big
need for this feature



This better?
Comment 8 Florian Müllner 2011-10-21 13:05:40 UTC 
Review of attachment 198280 [details] [review]:

Makes sense to me.
Comment 9 Jasper St. Pierre (not reading bugmail) 2011-10-21 13:17:54 UTC 
Attachment 198280 [details] pushed as d624e85 - frames: Disable the titlebar "inner resize"