After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660125 - Weird contacts in linking dialog
Weird contacts in linking dialog
Status: RESOLVED OBSOLETE
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-26 12:10 UTC by Guillaume Desmottes
Modified: 2013-03-21 11:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (18.36 KB, image/jpeg)
2011-09-26 12:10 UTC, Guillaume Desmottes 		  Details
Work around changes in how folks marks its eds addressbooks (2.77 KB, patch)
2011-09-26 12:49 UTC, Alexander Larsson 		none Details | Review

Description Guillaume Desmottes 2011-09-26 12:10:04 UTC 
See attached screenshot. Those 2 contacts looks pretty weird and confusing.
Comment 1 Guillaume Desmottes 2011-09-26 12:10:48 UTC 
Created attachment 197468 [details]
screenshot
Comment 2 Alexander Larsson 2011-09-26 12:15:25 UTC 
The keyfiles.ini is the old keyfiles backend. I guess we should hide those personas as they don't actually contain any info, just linking attributes.
Comment 3 Alexander Larsson 2011-09-26 12:37:33 UTC 
Ugh, the other one is the local contact.

The code:
  public static string format_persona_store_name (PersonaStore store) {
    if (store.type_id == "eds") {
      if (store.id == "system") {
	return _("Local Contact");
      }


Broke due to this change:
http://git.gnome.org/browse/folks/commit/?id=73647bc63e66c085bf0a1a7080df9734734c77b7
Comment 4 Alexander Larsson 2011-09-26 12:49:17 UTC 
Created attachment 197472 [details] [review]
Work around changes in how folks marks its eds addressbooks

Folks used to uave the relative uri as the eds store id, but
now switched to uid.
Comment 5 Alexander Larsson 2011-09-26 13:41:37 UTC 
pushed the patch
Comment 6 Guillaume Desmottes 2011-09-26 14:16:17 UTC 
Seems to work fine. So the last thing to fix is hidding the relationships.ini persona.
Comment 7 Allan Day 2013-03-21 11:16:45 UTC 
We don't have a linking dialog any more.