After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660108 - Do not make text in prompt dialog selectable
Do not make text in prompt dialog selectable
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: prompting
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-26 08:44 UTC by Vincent Untz
Modified: 2011-11-14 08:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not make label selectionnable in prompt dialog (22.10 KB, patch)
2011-09-26 08:49 UTC, Vincent Untz
none Details | Review
Do not make label selectionnable in prompt dialog (1.44 KB, patch)
2011-11-08 09:15 UTC, Vincent Untz
none Details | Review

Description Vincent Untz 2011-09-26 08:44:54 UTC
I was playing with autologin, and so got the "unlock your keyring" dialog. I clicked on it, right where the label is, and started typing my password.

This didn't work as the label in the dialog is selectable, which means that clicking there focuses the window, but also moves the focus to the label instead of leaving it to the entry.
Comment 1 Vincent Untz 2011-09-26 08:49:04 UTC
Created attachment 197452 [details] [review]
Do not make label selectionnable in prompt dialog

I just opened the file in glade and changed the property, but this results in a bigger diff than I'd like. Anyway, that should help.
Comment 2 Hernando Torque 2011-10-01 06:31:49 UTC
Is it also a gnome-keyring problem if that dialog doesn't have the focus after auto-login? Ideally I shouldn't need to take my hand off the keyboard at all.
Comment 3 Vincent Untz 2011-10-01 07:30:11 UTC
It's also a problem, but that's a different thing :-)
Comment 4 Stef Walter 2011-11-06 18:04:10 UTC
Vincent, that patch changes a lot of stuff, so I'd be hesitant to apply it to a stable branch. I realize that's just glade being annoying, but any chance for a smaller patch?
Comment 5 Vincent Untz 2011-11-08 09:15:36 UTC
Created attachment 200964 [details] [review]
Do not make label selectionnable in prompt dialog

This is smaller, but untested. Although I fail to see how it'd break things.
Comment 6 Stef Walter 2011-11-14 08:35:49 UTC
Thanks. Applied to gnome-keyring master.

I'm in the process of rewriting how the prompting works, so it integrates with gnome-shell (with fallback that is a normal dialog). I'll try and remember not to make text selectable in any prompts there as well.