After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660013 - Remove old g_atomic configure cruft
Remove old g_atomic configure cruft
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: build
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-09-24 15:22 UTC by Kean Johnston
Modified: 2011-09-30 03:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to remove old cruft (4.55 KB, patch)
2011-09-24 15:22 UTC, Kean Johnston 		none Details | Review
Patch to remove some old cruft (3.77 KB, patch)
2011-09-24 15:29 UTC, Kean Johnston 		needs-work Details | Review
Clean up atomic cruft (4.97 KB, patch)
2011-09-30 03:20 UTC, Matthias Clasen 		committed Details | Review

Description Kean Johnston 2011-09-24 15:22:44 UTC 
Created attachment 197403 [details] [review]
Patch to remove old cruft

There are tests left over in configure.ac and the pre-generated windows header file that are no longer relevant, all related to g_atomic stuff. The attached patch cleans this up.
Comment 1 Kean Johnston 2011-09-24 15:28:57 UTC 
Comment on attachment 197403 [details] [review]
Patch to remove old cruft

Sorry first patch attached was the wrong one. Correct one following.
Comment 2 Kean Johnston 2011-09-24 15:29:34 UTC 
Created attachment 197404 [details] [review]
Patch to remove some old cruft
Comment 3 Matthias Clasen 2011-09-30 00:27:12 UTC 
Review of attachment 197404 [details] [review]:

I think this should be gutted further. The messages before and in the switch don't make sense anymore.
Comment 4 Matthias Clasen 2011-09-30 03:20:35 UTC 
The following fix has been pushed:
e6c76d9 Clean up atomic cruft
Comment 5 Matthias Clasen 2011-09-30 03:20:39 UTC 
Created attachment 197839 [details] [review]
Clean up atomic cruft

Nothing is using these defines anymore, and the messages
are misleading. Based on a patch by Kean Johnston.