After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659989 - add some more Klondike variants
add some more Klondike variants
Status: RESOLVED OBSOLETE
Product: aisleriot
Classification: Other
Component: games
git master
Other Linux
: Normal enhancement
: ---
Assigned To: aisleriot-maint
aisleriot-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-24 06:27 UTC by Benjamin Shadwick
Modified: 2021-06-02 11:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Benjamin Shadwick 2011-09-24 06:27:48 UTC
Running AisleRiot Solitaire 2.32.1, which is packaged with Ubuntu/Xubuntu 11.04. In Klondike mode, the game does not allow redeals (which I believe is supposed to mean re-cycling of the draw deck after it is exhausted) regardless of whether or not "no redeals" is selected.
Comment 1 Jeremy Bicha 2011-09-24 17:52:19 UTC
I believe that is part of the rules that you can only redeal twice. Look in the status bar to see how many redeals you have left.
Comment 2 Christian Persch 2011-09-24 18:34:01 UTC
Maybe bug 641702 ?
Comment 3 Benjamin Shadwick 2011-09-24 18:39:51 UTC
Jeremy:

There are many variations of the dealing rules for Klondike (see http://en.wikipedia.org/wiki/Klondike_%28solitaire%29), but it seems that this particular implementation has a limit of two redeals in "single card deals" mode (unless "no redeals" is selected): http://library.gnome.org/users/aisleriot/stable/Klondike.html.en

I guess I'll try playing in "three card deals" mode, since the above link states that this mode allows unlimited redeals.

It seems to me that either the number of redeals should be de-coupled from the card drawing mode, or else more variations should be added.


Christian:

Thanks, but it looks like Jeremy is on the right track with it likely being an issue with the rules implementation.
Comment 4 Christian Persch 2011-10-05 20:17:58 UTC
So what's the conclusion here?
Comment 5 Benjamin Shadwick 2011-10-05 20:53:07 UTC
I think this would optimally be resolved by having separate settings for:
- the number of cards dealt at a time (possible values: {one, three}) and
- the number of redeals allowed (possible values: {none, one, unlimited}, or possibly a user-entered non-negative integer value).

If patches are welcome, let me know and I can try getting the GNOME development environment set up on one of my Linux boxes.
Comment 6 Christian Persch 2011-10-05 22:02:40 UTC
I'm not opposed to adding more variations (e.g. these mentioned on the wiki) to the 3 we already have, but I don't think we should allow configuring the number of redeals manually.
Comment 7 Benjamin Shadwick 2011-10-05 22:36:34 UTC
Do you mean you don't think entering a number should be allowed, or do you mean that not even selecting from a list should be allowed?
Comment 8 Christian Persch 2011-10-28 14:50:16 UTC
I mean they shouldn't be selectable individually and separately, but only set together as part of a game variant.
Comment 9 Benjamin Shadwick 2011-10-28 15:36:58 UTC
I can live with that, although after googling for solitaire rules I'm curious as to why you feel that way:

The Wikipedia list of variations is not by any means definitive; here's a completely different list: http://www.solitairecity.com/Help/Klondike_Rules.shtml

And here are yet more links suggesting two-redeals variants which are not mentioned on either of the previous links:
http://www.solitaire-game.com/klondike-solitaire.htm
http://www.solitairecentral.com/rules/Klondike.html

Throwing in the following link, I've now seen almost every combination mentioned of deal 1/3 and 0/1/2/3/unlimited redeals: http://www.solitairegames.com/klondike.html
Comment 10 GNOME Infrastructure Team 2021-06-02 11:41:40 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/aisleriot/-/issues/166.