After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659969 - Please add translator comment for "looking glass dialog"
Please add translator comment for "looking glass dialog"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: looking-glass
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-23 20:45 UTC by Peter Mráz
Modified: 2015-07-26 11:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add translator comment (969 bytes, patch)
2015-07-15 08:46 UTC, Alexandre Franke 		none Details | Review
Add translator comment (1019 bytes, patch)
2015-07-15 10:37 UTC, Alexandre Franke 		committed Details | Review

Description Peter Mráz 2011-09-23 20:45:43 UTC 
#: ../data/org.gnome.shell.gschema.xml.in.h:7
msgid "History for the looking glass dialog"

What is looking glass dialog.
Please add translation comment
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-09-23 20:47:41 UTC 
https://live.gnome.org/GnomeShell/LookingGlass
Comment 2 André Klapper 2011-10-03 11:05:27 UTC 
Please use descriptive descriptions and please ALWAYS provide a link for
developers describing what translation comments are.

https://live.gnome.org/TranslationProject/DevGuidelines/Use%20comments
Comment 3 Alexandre Franke 2015-07-15 08:46:52 UTC 
Created attachment 307452 [details] [review]
Add translator comment

Explain what looking glass is.
Comment 4 Rui Matos 2015-07-15 09:43:29 UTC 
Review of attachment 307452 [details] [review]:

just a nit pick below, fine either way

::: data/org.gnome.shell.gschema.xml.in.in
@@ +51,3 @@
     </key>
     <key name="looking-glass-history" type="as">
+      <default><!-- Translators: looking glass is a debugger and inspector tool, see https://live.gnome.org/GnomeShell/LookingGlass -->[]</default>

Can you put this in its own line like:

<default>..
<!-- Translators... -->
<_summary>..
Comment 5 Rui Matos 2015-07-15 09:43:31 UTC 
Review of attachment 307452 [details] [review]:

just a nit pick below, fine either way

::: data/org.gnome.shell.gschema.xml.in.in
@@ +51,3 @@
     </key>
     <key name="looking-glass-history" type="as">
+      <default><!-- Translators: looking glass is a debugger and inspector tool, see https://live.gnome.org/GnomeShell/LookingGlass -->[]</default>

Can you put this in its own line like:

<default>..
<!-- Translators... -->
<_summary>..
Comment 6 Alexandre Franke 2015-07-15 10:37:53 UTC 
Created attachment 307461 [details] [review]
Add translator comment
Comment 7 Alexandre Franke 2015-07-15 10:38:35 UTC 
Attachment 307461 [details] pushed as eaa3f83 - Add translator comment
Comment 8 Piotr Drąg 2015-07-15 18:47:21 UTC 
(In reply to Alexandre Franke from comment #6)
> Created attachment 307461 [details] [review] [review]
> Add translator comment

This doesn't work. You need to make it like Rui suggested to appear in the PO files.
Comment 9 Alexandre Franke 2015-07-15 19:46:28 UTC 
I don't get the difference. Can you fix it?
Comment 11 Alexandre Franke 2015-07-15 21:06:37 UTC 
Ah! But https://wiki.gnome.org/TranslationProject/DevGuidelines/Use%20comments states that comments "need to be inside <default>, <short> or <long> elements"!
Comment 12 André Klapper 2015-07-26 11:25:58 UTC 
(In reply to Alexandre Franke from comment #11)
> Ah! But
> https://wiki.gnome.org/TranslationProject/DevGuidelines/Use%20comments
> states that comments "need to be inside <default>, <short> or <long>
> elements"!

Looks like it worked nevertheless, looking at https://l10n.gnome.org/POT/gnome-shell.master/gnome-shell.master.cs.po
Anybody up to updating the docs?