After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659940 - JS exception in ~/.xsession-errors: this.actor is null
JS exception in ~/.xsession-errors: this.actor is null
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: keyboard
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-23 12:55 UTC by Vincent Untz
Modified: 2011-09-29 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media: handle dialog closing consistently (1.27 KB, patch)
2011-09-24 00:27 UTC, Matthias Clasen 		none Details | Review
main: remove a stray second keyboard.init() call (887 bytes, patch)
2011-09-28 12:53 UTC, Dan Winship 		committed Details | Review
keyboard: ignore D-Bus requests when the OSK isn't enabled (1.28 KB, patch)
2011-09-28 12:53 UTC, Dan Winship 		committed Details | Review

Description Vincent Untz 2011-09-23 12:55:24 UTC 
I see this exception quite a bit in ~/.xsession-errors:

dbus.exceptions.DBusException: org.freedesktop.DBus.Error.Failed: TypeError: this.actor is null
    JS ERROR: !!!   Exception was: TypeError: this.actor is null
    JS ERROR: !!!     lineNumber = '473'
    JS ERROR: !!!     fileName = '"/usr/share/gnome-shell/js/ui/keyboard.js"'
    JS ERROR: !!!     stack = '"(32,463)@/usr/share/gnome-shell/js/ui/keyboard.js:473
(32,463,8,15)@/usr/share/gnome-shell/js/ui/keyboard.js:495
"'
    JS ERROR: !!!     message = '"this.actor is null"'

(this is with 3.1.92)
Comment 1 Dan Winship 2011-09-23 12:59:54 UTC 
The code that would cause that warning is now commented out (bug 659643), though this will still need to be fixed when that's brought back.
Comment 2 Matthias Clasen 2011-09-24 00:27:46 UTC 
Created attachment 197379 [details] [review]
media: handle dialog closing consistently

The 'Other media' dialog is just hidden when the close button is
clicked (so that it can be shown again), but when closing it with
the Escape key, it gets destroyed and an attempt to bring it up
again just shows a sad empty little square.
Comment 3 Matthias Clasen 2011-09-24 00:28:16 UTC 
Uh sorry, I misattached
Comment 4 Dan Winship 2011-09-28 12:53:00 UTC 
Created attachment 197657 [details] [review]
main: remove a stray second keyboard.init() call

Originally the keyboard was initialized in the user-session-specific
code, but it was later moved to the generic code. Except that it was
accidentally copied rather than moved.

====

(not actually related, but noticed in passing)
Comment 5 Dan Winship 2011-09-28 12:53:10 UTC 
Created attachment 197658 [details] [review]
keyboard: ignore D-Bus requests when the OSK isn't enabled
Comment 6 Colin Walters 2011-09-29 14:18:07 UTC 
Review of attachment 197657 [details] [review]:

Ok.
Comment 7 Colin Walters 2011-09-29 14:18:37 UTC 
Review of attachment 197658 [details] [review]:

This looks safe.  But are you saying it actually fix this bug?  If so it'd be good to mention in the commit message.
Comment 8 Dan Winship 2011-09-29 14:30:48 UTC 
pushed with updated commit message

Attachment 197657 [details] pushed as 9c76318 - main: remove a stray second keyboard.init() call
Attachment 197658 [details] pushed as 6aa411f - keyboard: ignore D-Bus requests when the OSK isn't enabled