After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659865 - keep the fallback caribou keyboard from showing up in the shell
keep the fallback caribou keyboard from showing up in the shell
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 659750 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-22 19:48 UTC by Dan Winship
Modified: 2011-09-23 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: fix D-Bus name acquisition flags to totally block Antler (1.13 KB, patch)
2011-09-22 19:48 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-09-22 19:48:21 UTC 
this requires a caribou patch too (to make it use ALLOW_REPLACEMENT)
Comment 1 Dan Winship 2011-09-22 19:48:23 UTC 
Created attachment 197286 [details] [review]
keyboard: fix D-Bus name acquisition flags to totally block Antler

We never want the antler keyboard to run if gnome-shell is running, so
grab org.gnome.Caribou.Keyboard without the "allow replacement" flag.
Comment 2 Colin Walters 2011-09-22 20:36:40 UTC 
Review of attachment 197286 [details] [review]:

::: src/main.c
@@ +121,3 @@
   if (!dbus_g_proxy_call (bus, "RequestName", &error,
                           G_TYPE_STRING, "org.gnome.Caribou.Keyboard",
+                          G_TYPE_UINT, DBUS_NAME_FLAG_REPLACE_EXISTING,

Note we're also losing _DO_NOT_QUEUE here.  But not a big deal because we say REPLACE_EXISTING which effectively renders _DO_NOT_QUEUE irrelevant.  Just double checked in the dbus code, this is fine.
Comment 3 Matthias Clasen 2011-09-22 20:49:00 UTC 
Works fine in my testing.
Comment 4 Dan Winship 2011-09-23 11:52:04 UTC 
*** Bug 659750 has been marked as a duplicate of this bug. ***
Comment 5 Dan Winship 2011-09-23 11:54:13 UTC 
Attachment 197286 [details] pushed as 5adb541 - keyboard: fix D-Bus name acquisition flags to totally block Antler