After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659861 - With 2 monitors, message tray appears on wrong monitor
With 2 monitors, message tray appears on wrong monitor
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-22 19:28 UTC by Gary van der Merwe
Modified: 2011-09-29 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (786.88 KB, image/png)
2011-09-22 19:28 UTC, Gary van der Merwe
  Details
boxpointer: Don't constrain box pointer to primary monitor (3.60 KB, patch)
2011-09-22 19:56 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Gary van der Merwe 2011-09-22 19:28:42 UTC
Created attachment 197283 [details]
Screenshot

gnome-shell 3.1.92-1 from arch gnome-unstable

I have 2 monitors. 

Actual:

The top bar of gnome-shell is on the left monitor.
The message tray now appears on the right monitor
Notification appear on the right, but
if I click on a icon in the message tray, the menu appears on the left monitor. 

Expected:
Everything mentioned on the left, as before.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-09-22 19:56:32 UTC
Created attachment 197287 [details] [review]
boxpointer: Don't constrain box pointer to primary monitor

A boxPointer should be able to be attached to any actor, not just ones on the
primary monitor. Assume that the sourceActor doesn't straddle monitors, and
constrain the boxPointer to the monitor the sourceActor is on.


--

Untested patch to fix the multimon issues with the summary pointer. Not
sure why your second monitor is getting marked as the "bottom" monitor.
Comment 2 Gary van der Merwe 2011-09-23 08:04:03 UTC
So my monitors were layed out like this:

 __________
|          |_________
| LVDS     |         |
|          | VGA     |
|__________|_________|


When I chaged it to following, the problem went away:

 ____________________
|          |         |
| LVDS     | VGA     |
|          |_________|
|__________|


I'll give your patch a try on the weekend.
Comment 3 Dan Winship 2011-09-23 13:26:06 UTC
Comment on attachment 197287 [details] [review]
boxpointer: Don't constrain box pointer to primary monitor

yes, looks good
Comment 4 Dan Winship 2011-09-23 13:28:52 UTC
(In reply to comment #2)
> So my monitors were layed out like this:
> 
>  __________
> |          |_________
> | LVDS     |         |
> |          | VGA     |
> |__________|_________|
> 
> 
> When I chaged it to following, the problem went away:
> 
>  ____________________
> |          |         |
> | LVDS     | VGA     |
> |          |_________|
> |__________|
> 
> 
> I'll give your patch a try on the weekend.

Yes, there seem to be multiple problems with the layout code:

  1. a monitor is considered above-or-below the primary when it is
     merely touching it on the left or right edge

  2. a monitor is considered below the primary if its top is
     below the primary's top (rather than if its bottom is below
     the primary's bottom)

Given Jasper's fix, I think we can survive with this until 3.2.1. Most people top-align their monitors rather than bottom-aligning them anyway.
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-09-29 17:15:20 UTC
Attachment 197287 [details] pushed as 7a8a189 - boxpointer: Don't constrain box pointer to primary monitor