After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659834 - The page 'gkr-keyring' was not found in the document 'ghelpseahorse'.
The page 'gkr-keyring' was not found in the document 'ghelpseahorse'.
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
: 685111 702572 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-22 15:28 UTC by Pedro Villavicencio
Modified: 2013-08-16 16:32 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6


Attachments
Untested Patch (884 bytes, patch)
2012-08-27 23:35 UTC, André Klapper
none Details | Review
Tested patch against 3.6 (1.02 KB, patch)
2012-10-17 17:30 UTC, Sebastien Bacher
none Details | Review
remove help button (2.53 KB, patch)
2013-02-18 21:32 UTC, Michael Catanzaro
rejected Details | Review
try #2 (4.09 KB, patch)
2013-02-18 22:10 UTC, Michael Catanzaro
none Details | Review

Description Pedro Villavicencio 2011-09-22 15:28:36 UTC
this report has been filed here:

https://bugs.launchpad.net/ubuntu/+source/seahorse/+bug/853137

"seahorse > (Passsword and Keyss) > [tab] Passwords > Passwors: default> [right-click] Properties > "Passwords:default" > (dialog window "Passwords:default") > Keyring > Name:=default, Created:=(empty) > Help > (Help) > "PageNotFound": > The page 'gkr-keyring' was not found in the document 'ghelpseahorse'.

"
Comment 1 André Klapper 2011-11-15 11:26:52 UTC
Confirming on Fedora 16 (though 'ghelpseahorse' is 'ghelp:seahorse').
Comment 2 Sebastien Bacher 2012-08-27 22:30:50 UTC
seems to still be an issue with GNOME 3.4
Comment 3 André Klapper 2012-08-27 23:35:46 UTC
Created attachment 222596 [details] [review]
Untested Patch

I don't have a build environment on this machine so this is just a guess based on the code.
Comment 4 Sebastien Bacher 2012-09-03 15:35:44 UTC
the widget name is used in the code so maybe not the right way to deal with that,

"seahorse_widget_show_help (SeahorseWidget *swidget)
{
...
    if (g_str_equal (swidget->name, "key-manager") || 
        g_str_equal (swidget->name, "keyserver-results")) {
        document = g_strdup ("ghelp:" PACKAGE "?introduction");
    } else {
        document = g_strdup_printf ("ghelp:" PACKAGE "?%s", swidget->name);"
"

there should perhaps be another special case in that function? 

    if (g_str_equal (swidget->name, "gkr-keyring"))
      document = g_strdup ("ghelp:" PACKAGE "?keyring");
Comment 5 Sebastien Bacher 2012-09-03 15:36:30 UTC
still an issue with seahorse 3.5.90, right click on a keyring in the left side of the main ui, properties, help -> error
Comment 6 Jeremy Bicha 2012-09-19 03:11:22 UTC
Also, gkr-item-properties is another broken help link. You can find that by right-clicking on a saved password in the login keyring and selecting Properties.

I think the Password Keyring properties dialog should just be killed. It has zero information even if you create a new keyring in addition to the login one.

The help button in the keyring item properties dialog should probably be removed since there is no help page that actually discusses saved passwords in particular.
Comment 7 André Klapper 2012-09-29 23:34:58 UTC
(In reply to comment #6)
> Also, gkr-item-properties is another broken help link.

bug 685111
Comment 8 Sebastien Bacher 2012-10-17 17:30:40 UTC
Created attachment 226664 [details] [review]
Tested patch against 3.6

The patch will redirect to help:seahorse/keyring for the two cases listed as buggy on the report
Comment 9 Michael Catanzaro 2013-02-11 23:29:00 UTC
For 3.8, can we please either hide this button (seems best) or else apply the patch above?
Comment 10 Michael Catanzaro 2013-02-18 21:32:40 UTC
Created attachment 236668 [details] [review]
remove help button

Alternative patch to remove the button entirely. (I don't really like the button going to the Preferences help page... that's pretty unrelated.)
Comment 11 Michael Catanzaro 2013-02-18 21:48:23 UTC
Review of attachment 236668 [details] [review]:

Missed a spot
Comment 12 Michael Catanzaro 2013-02-18 22:10:26 UTC
Created attachment 236670 [details] [review]
try #2

I've gotten the one on (generic; non pgp/ssh) keyring elements and also the one under password keyring properties (View -> By Keyring). I don't *think* there's any other bad button hiding around; could be wrong.
Comment 13 André Klapper 2013-02-23 11:46:21 UTC
code => reassign from docs team to devs
Comment 14 Stef Walter 2013-02-26 10:44:40 UTC
Jim, does the mallard based help make sense here? Is the plan with mallard to keep the various help buttons in the dialogs, or just remove them, aim to have more understandable dialogs, and have help be higher level concept?
Comment 15 Jeremy Bicha 2013-06-29 14:54:37 UTC
*** Bug 685111 has been marked as a duplicate of this bug. ***
Comment 16 Jeremy Bicha 2013-06-29 14:54:44 UTC
*** Bug 702572 has been marked as a duplicate of this bug. ***
Comment 17 Michael Catanzaro 2013-08-14 02:55:13 UTC
Stef, can this be fixed for 3.10?
Comment 18 Stef Walter 2013-08-14 07:13:11 UTC
Aruna, are you planning on merging the seahorse mallard help for 3.10? I have the following question about them:

(In reply to comment #14)
> Jim, does the mallard based help make sense here? Is the plan with mallard to
> keep the various help buttons in the dialogs, or just remove them, aim to have
> more understandable dialogs, and have help be higher level concept?

If so, then we can apply Michael's patch and remove the help button.
Comment 19 Stef Walter 2013-08-16 16:32:01 UTC
Looks like I made this change as part of this commit. Sorry for the delay, but it should be fixed in 3.10

commit 7b202f99b4f66f4b13ae610be4159382cb98ec59
Author: Stef Walter <stefw@gnome.org>
Date:   Thu Jun 20 17:09:39 2013 +0200

    gkr: Port the gnome-keyring/libsecret stuff to vala