GNOME Bugzilla – Bug 659834
The page 'gkr-keyring' was not found in the document 'ghelpseahorse'.
Last modified: 2013-08-16 16:32:01 UTC
this report has been filed here: https://bugs.launchpad.net/ubuntu/+source/seahorse/+bug/853137 "seahorse > (Passsword and Keyss) > [tab] Passwords > Passwors: default> [right-click] Properties > "Passwords:default" > (dialog window "Passwords:default") > Keyring > Name:=default, Created:=(empty) > Help > (Help) > "PageNotFound": > The page 'gkr-keyring' was not found in the document 'ghelpseahorse'. "
Confirming on Fedora 16 (though 'ghelpseahorse' is 'ghelp:seahorse').
seems to still be an issue with GNOME 3.4
Created attachment 222596 [details] [review] Untested Patch I don't have a build environment on this machine so this is just a guess based on the code.
the widget name is used in the code so maybe not the right way to deal with that, "seahorse_widget_show_help (SeahorseWidget *swidget) { ... if (g_str_equal (swidget->name, "key-manager") || g_str_equal (swidget->name, "keyserver-results")) { document = g_strdup ("ghelp:" PACKAGE "?introduction"); } else { document = g_strdup_printf ("ghelp:" PACKAGE "?%s", swidget->name);" " there should perhaps be another special case in that function? if (g_str_equal (swidget->name, "gkr-keyring")) document = g_strdup ("ghelp:" PACKAGE "?keyring");
still an issue with seahorse 3.5.90, right click on a keyring in the left side of the main ui, properties, help -> error
Also, gkr-item-properties is another broken help link. You can find that by right-clicking on a saved password in the login keyring and selecting Properties. I think the Password Keyring properties dialog should just be killed. It has zero information even if you create a new keyring in addition to the login one. The help button in the keyring item properties dialog should probably be removed since there is no help page that actually discusses saved passwords in particular.
(In reply to comment #6) > Also, gkr-item-properties is another broken help link. bug 685111
Created attachment 226664 [details] [review] Tested patch against 3.6 The patch will redirect to help:seahorse/keyring for the two cases listed as buggy on the report
For 3.8, can we please either hide this button (seems best) or else apply the patch above?
Created attachment 236668 [details] [review] remove help button Alternative patch to remove the button entirely. (I don't really like the button going to the Preferences help page... that's pretty unrelated.)
Review of attachment 236668 [details] [review]: Missed a spot
Created attachment 236670 [details] [review] try #2 I've gotten the one on (generic; non pgp/ssh) keyring elements and also the one under password keyring properties (View -> By Keyring). I don't *think* there's any other bad button hiding around; could be wrong.
code => reassign from docs team to devs
Jim, does the mallard based help make sense here? Is the plan with mallard to keep the various help buttons in the dialogs, or just remove them, aim to have more understandable dialogs, and have help be higher level concept?
*** Bug 685111 has been marked as a duplicate of this bug. ***
*** Bug 702572 has been marked as a duplicate of this bug. ***
Stef, can this be fixed for 3.10?
Aruna, are you planning on merging the seahorse mallard help for 3.10? I have the following question about them: (In reply to comment #14) > Jim, does the mallard based help make sense here? Is the plan with mallard to > keep the various help buttons in the dialogs, or just remove them, aim to have > more understandable dialogs, and have help be higher level concept? If so, then we can apply Michael's patch and remove the help button.
Looks like I made this change as part of this commit. Sorry for the delay, but it should be fixed in 3.10 commit 7b202f99b4f66f4b13ae610be4159382cb98ec59 Author: Stef Walter <stefw@gnome.org> Date: Thu Jun 20 17:09:39 2013 +0200 gkr: Port the gnome-keyring/libsecret stuff to vala