After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659823 - [legacyh264parse] set "parsed" and "framed" caps
[legacyh264parse] set "parsed" and "framed" caps
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.31
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-22 12:42 UTC by Stas Sergeev
Modified: 2011-09-26 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the patch (1.84 KB, patch)
2011-09-22 12:42 UTC, Stas Sergeev
none Details | Review

Description Stas Sergeev 2011-09-22 12:42:02 UTC
Created attachment 197241 [details] [review]
the patch

Hi.

The subject says it all. :)
Patch attached.
Comment 1 Sebastian Dröge (slomo) 2011-09-22 12:49:38 UTC
Why is this necessary? If the alignment and stream-format fields are available in the caps you can assume correctly framed h264
Comment 2 Stas Sergeev 2011-09-22 13:08:13 UTC
Is there anywhere the list of all caps with description?
I guess stream-format implies parsed, and alignment
implies framed, but then, is it specific to h264 parser,
or is it common?
I assume that framed and parsed are common, so I can
just use those, instead of testing for the list of caps
I have no idea about. And these are booleans, while
stream-format/alignment are strings.
I just need the _simplest_ way to find out that the
stream is parsed and framed, so what would it be?
Comment 3 Stas Sergeev 2011-09-22 13:16:43 UTC
I tested my packetizer plugin with aacparse and ac3parse, and
I used parsed/framed because these parsers sets those.
It would be an inconvenience to adapt my plugin for every
other parser: it is better to get all the parsers to set the
needed common caps, that's the idea.
Comment 4 Sebastian Dröge (slomo) 2011-09-22 13:25:23 UTC
That's not standardized and you have to do it different for the different formats. What do you intend to do with parsed/framed streams for which you don't do anything format specific?
Comment 5 Stas Sergeev 2011-09-22 13:41:07 UTC
Basically, I use "framed" streams to assume the good
pes packet sizes, and I use "parsed" as a grant of
the timestamps presence. Of course it is possible to
packetize the unparsed and unframed stream, but the
result will be of no practical use I suppose.
Also, why do you see wrong to let all the parsers/framers
to set parsed/framed where appropriate? If these 2 booleans
where not standardized before, lets just do that right here,
right now. :)
Comment 6 Stas Sergeev 2011-09-23 11:13:52 UTC
OK, I've found this:
https://bugzilla.gnome.org/show_bug.cgi?id=606662
So the problem with framed=true is that it doesn't give
enough info, like the "alignment" does. But the reason
for removing it was not clearly stated, and it might
happen that some packetizer do not care about the particular
alignment in use, so it may go on with just "framed=true".
As for "parsed" - I guess I'll get rid of that one since
its vague. And it was _removed_ from h264parse at some
point, while "framed" was never removed (nor added) AFAICS.

So my question reduces to why not to add only "framed" for
some poor packetizers.
Comment 7 Stas Sergeev 2011-09-23 11:53:14 UTC
> As for "parsed" - I guess I'll get rid of that one since
> its vague.
But then there is no cap to indicate the presence
of timestamps that I use for pts...
Comment 8 David Schleef 2011-09-24 21:28:26 UTC
I don't see a bug here.

If you want framed data, specify what kind of framing you want in the pad template caps.  H.264 has multiple bitstream formats and framing options, so a true/false will never work.
Comment 9 Stas Sergeev 2011-09-24 21:38:19 UTC
What if I need _any_ reasonable framing to just
packetize the stream into PES?
Comment 10 Sebastian Dröge (slomo) 2011-09-26 09:41:29 UTC
Where would you need any framing?
Comment 11 Stas Sergeev 2011-09-26 11:57:22 UTC
When packetizing... but I guess I need the
AU boundaries for PES anyway, so nevermind.