GNOME Bugzilla – Bug 659768
Handle icons in notifications better and update the avatar when it changes
Last modified: 2011-10-17 20:04:14 UTC
Previously, when the avatar changed, we would not update the summary icon for the source at all and would only update the notification icon when the next message was received. Instead, we should update both immediately upon recieving the signal that the avatar has changed.
Created attachment 197190 [details] [review] telepathyClient: update the avatar correctly when it changes
Created attachment 197191 [details] [review] messageTray: only update an icon when necessary on notification update This avoids unnecessarily removing and resetting the icon in the notifications. This fixes the new chat notification sliding down and up slightly when new messages are received.
Created attachment 197192 [details] A screenshot of a summary chat notification with inconsistent icons This is what would happen when avatar was updated before - the notification's icon would get updated when the next message is received and the source summary icon would not get updated at all.
Comment on attachment 197190 [details] [review] telepathyClient: update the avatar correctly when it changes looks ok
Created attachment 199261 [details] [review] notificationDaemon: only display a large image if icon is also specified Historically, when applications set "image-data" they expect it to show up as an icon. So we display it as such if an icon is not specified with an "app_icon" argument to Notify(). We only display a large image specified with "image-data" or "image-path" if an icon is also specified. This is an alternative fix to hardcoding Rhythmbox. The abrt, Firefox download complete, and Rhythmbox notifications look the same. There are no known applications that specify both "app_icon" argument and ("image-data" or "image-path"), but don't want an additional image to be displayed. This approach is better, as it will allow other applications such as Banshee to also display large images in notifications.
Comment on attachment 199261 [details] [review] notificationDaemon: only display a large image if icon is also specified Sorry, wrong number.