After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659632 - details-layout: tweak grid column/row spacing
details-layout: tweak grid column/row spacing
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-20 18:22 UTC by Cosimo Cecchi
Modified: 2011-09-21 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
details-layout: tweak grid column/row spacing (1.52 KB, patch)
2011-09-20 18:22 UTC, Cosimo Cecchi 		none Details | Review
Fix GtkGrid spacing (4.49 KB, patch)
2011-09-21 08:43 UTC, Alexander Larsson 		committed Details | Review

Description Cosimo Cecchi 2011-09-20 18:22:29 UTC 
See attached patch
Comment 1 Cosimo Cecchi 2011-09-20 18:22:30 UTC 
Created attachment 197103 [details] [review]
details-layout: tweak grid column/row spacing

The contacts grid looks quite tight currently.
I believe the spacings in the DetailsLayout GtkGrid are wrong, maybe due
to this [1] change that swapped those properties in GTK+ some time ago?
Anyway, I find this patch makes things a bit better, so I am attaching
it here.

[1] http://git.gnome.org/browse/gtk+/commit/gtk/gtkgrid.c?id=d717a2dcfc8603561f8a0f78982244e8b8fd9006
Comment 2 Alexander Larsson 2011-09-21 08:43:23 UTC 
Created attachment 197130 [details] [review]
Fix GtkGrid spacing

GtkGrid swapped behaviour with set_column_spacing and set_row_spacing,
this updates our use of these to the new behaviour.
Comment 3 Alexander Larsson 2011-09-21 08:44:08 UTC 
There are more places that needed fixing, attached an updated patch.
Comment 4 Alexander Larsson 2011-09-21 14:06:21 UTC 
Attachment 197130 [details] pushed as 6723106 - Fix GtkGrid spacing