After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659502 - tempfile suffix incorrectly set to 'None' for the temporary binary
tempfile suffix incorrectly set to 'None' for the temporary binary
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
2.29.x
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-19 18:20 UTC by Dieter Verfaillie
Modified: 2015-02-07 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix incorrect extension for tempfile (1.04 KB, patch)
2011-09-19 18:21 UTC, Dieter Verfaillie 		committed Details | Review

Description Dieter Verfaillie 2011-09-19 18:20:02 UTC 
I set ext to None in commit f2a70843905839a1b11795310d2aa3b85a474e77
without realizing _generate_tempfile does a simple string formatting.
A simple test proves this does not generate an empty string:

$ python -c "f = '%s' % None; print f, type(f)"
None <type 'str'>

So pass an empty string instead of None for the suffix parameter.
Comment 1 Dieter Verfaillie 2011-09-19 18:21:41 UTC 
Created attachment 196987 [details] [review]
Fix incorrect extension for tempfile
Comment 2 Colin Walters 2011-09-19 18:24:44 UTC 
Review of attachment 196987 [details] [review]:

Looks good, thanks for the quick fix.
Comment 3 Dieter Verfaillie 2011-09-19 18:36:14 UTC 
 [20:26] <dieterv> walters: do I have to request a code freeze exception before pushing, or is the freeze not yet in effect?
 [20:31] <walters> i actually don't know at what hour the freeze technically starts
 [20:31] <walters> but you have my 1/2 as R-T to push this

Committed & pushed. Thanks for spotting & reviewing this and allowing the
fix to get in!
Comment 4 André Klapper 2015-02-07 17:01:32 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]