After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659474 - Gtk-WARNING **: Overriding tab label for notebook
Gtk-WARNING **: Overriding tab label for notebook
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-19 13:46 UTC by Guillaume Desmottes
Modified: 2011-09-27 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
accounts-dialog: remove label2 tab child (1.16 KB, patch)
2011-09-19 13:49 UTC, Guillaume Desmottes
none Details | Review
accounts-dialog: remove useless childs (1.62 KB, patch)
2011-09-27 13:05 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2011-09-19 13:46:51 UTC
We have this warning when starting empathy-accounts:

Gtk-WARNING **: Overriding tab label for notebook
Comment 1 Guillaume Desmottes 2011-09-19 13:49:04 UTC
Created attachment 196943 [details] [review]
accounts-dialog: remove label2 tab child

It doesn't seem to be used and was raising a Gtk+ warning.
Comment 2 Xavier Claessens 2011-09-27 11:47:24 UTC
there is also the the placeholder that is useless as far as I can tell. I would remove the end of childs of the notebook:

        <child>
          <placeholder/>
        </child>
        <child type="tab">
          <object class="GtkLabel" id="label3">
            <property name="visible">True</property>
            <property name="label">page 3</property>
          </object>
          <packing>
            <property name="position">2</property>
            <property name="tab_fill">False</property>
          </packing>
        </child>

As far as I can tell, that defines a third page on the GtkNotebook but with no widget in it.
Comment 3 Guillaume Desmottes 2011-09-27 13:05:05 UTC
Created attachment 197567 [details] [review]
accounts-dialog: remove useless childs

They don't seem to be used and were raising a Gtk+ warning.
Comment 4 Guillaume Desmottes 2011-09-27 13:09:26 UTC
Merged to master.

Attachment 197567 [details] pushed as 32152c0 - accounts-dialog: remove useless childs