Bug 659439 – empathy-CRITICAL **: account_join_chatrooms: assertion `conn != NULL' failed

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 659439 - empathy-CRITICAL **: account_join_chatrooms: assertion `conn != NULL' failed


Summary:	empathy-CRITICAL **: account_join_chatrooms: assertion `conn != NULL' failed


Status:	RESOLVED FIXED

Product:	empathy
Classification:	Core
Component:	Multi User Chat
Version:	2.33.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	empathy-maint
QA Contact:

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2011-09-19 08:52 UTC by Guillaume Desmottes
Modified:	2011-09-19 12:01 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Don't assume a connected TpAccount always have a TpConnection (2.05 KB, patch) 2011-09-19 11:51 UTC, Guillaume Desmottes	committed	Details \| Review

Description Guillaume Desmottes 2011-09-19 08:52:39 UTC

I just got this crash:

empathy-CRITICAL **: account_join_chatrooms: assertion `conn != NULL' failed

+ Trace 228488

#0 g_logv
at gmessages.c line 570
#1 g_log
at gmessages.c line 591
#2 g_return_if_fail_warning
at gmessages.c line 600
#3 account_join_chatrooms
at empathy.c line 681
#4 account_status_changed_cb
at empathy.c line 708
#5 _tp_marshal_VOID__UINT_UINT_UINT_STRING_BOXED
at _gen/signals-marshal.c line 3359
#6 g_closure_invoke
at gclosure.c line 773
#7 signal_emit_unlocked_R
at gsignal.c line 3271
#8 g_signal_emit_valist
at gsignal.c line 3002
#9 g_signal_emit
at gsignal.c line 3059
#10 _tp_account_update
at account.c line 847
#11 _tp_account_properties_changed
at account.c line 920
#12 _tp_cli_account_invoke_callback_for_account_property_changed
at ../telepathy-glib/_gen/tp-cli-account-body.h line 94
#13 tp_proxy_signal_invocation_run
at proxy-signals.c line 266
#14 g_idle_dispatch
at gmain.c line 4780
#15 g_main_dispatch
at gmain.c line 2439
#16 g_main_context_dispatch
at gmain.c line 3008
#17 g_main_context_iterate
at gmain.c line 3086
#18 g_main_loop_run
at gmain.c line 3294
#19 gtk_main
at gtkmain.c line 1362
#20 gtk_application_run_mainloop
at gtkapplication.c line 115
#21 g_application_run
at gapplication.c line 1325
#22 main
at empathy.c line 845

Comment 1 Guillaume Desmottes 2011-09-19 11:51:45 UTC

Created attachment 196927 [details] [review]
Don't assume a connected TpAccount always have a TpConnection

The connection object may not be there yet if tp-glib is still preparing its
features.

Comment 2 Guillaume Desmottes 2011-09-19 12:01:51 UTC

Attachment 196927 [details] pushed as be57ef7 - Don't assume a connected TpAccount always have a TpConnection