Created attachment 196787 [details] [review]
log-window: improve icons in the search entry

There are a few improvements we can make to the search entry icons in
the log window, which this patch tries to fix.
- icons in entries are usually symbolic in GNOME 3, so I made the icons
  symbolic.
- I merged the two icons in just one on the right using the shell-style,
  i.e. the search icon turns into a clear action once there's some text
  typed into the entry (Documents also uses the same style for its
  search entry).

Review of attachment 196787 [details] [review]:

Looks mostly good but we should ask an exception as that's an UI change.

::: libempathy-gtk/empathy-log-window.c
@@ +2030,3 @@
+  str = gtk_entry_get_text (GTK_ENTRY (self->priv->search_entry));
+
+  if ((str != NULL) && (str[0] != '\0'))

Use tp_str_empty().

Attachment 196787 [details] pushed as 0d24698 - log-window: improve icons in the search entry

Release and Doc teams gave their approvals, so I fixed the patch to use tp_str_empty() and pushed it to master.