After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659274 - popup-menu: Allow adjusting where in the source the arrow point to
popup-menu: Allow adjusting where in the source the arrow point to
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 659275
 
 
Reported: 2011-09-16 17:44 UTC by Florian Müllner
Modified: 2011-10-13 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
popup-menu: Allow adjusting where in the source the arrow point to (2.87 KB, patch)
2011-09-16 17:44 UTC, Florian Müllner 		none Details | Review
popup-menu: Allow adjusting where in the source the arrow point to (3.64 KB, patch)
2011-10-12 23:55 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-09-16 17:44:50 UTC 
See patch. I'm not entirely happy with the terminology, but wasn't able to come up with something better for now ...
Comment 1 Florian Müllner 2011-09-16 17:44:53 UTC 
Created attachment 196758 [details] [review]
popup-menu: Allow adjusting where in the source the arrow point to

Currently BoxPointer/Menus always point to the center of the
associated source actor. This is generally what we want, but
add some API to adjust that behavior for the cases where it
isn't.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-10-12 22:40:06 UTC 
Review of attachment 196758 [details] [review]:

How is this different than the alignment property passed into reposition (and into _init)?
Comment 3 Florian Müllner 2011-10-12 22:48:31 UTC 
(In reply to comment #2)
> Review of attachment 196758 [details] [review]:
> 
> How is this different than the alignment property passed into reposition (and
> into _init)?

The existing alignment refers to the position of the pointer with regard to the menu, the new alignment refers to the position of the pointer (and the menu) with regard to the source actor.
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-10-12 22:57:21 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Review of attachment 196758 [details] [review] [details]:
> > 
> > How is this different than the alignment property passed into reposition (and
> > into _init)?
> 
> The existing alignment refers to the position of the pointer with regard to the
> menu, the new alignment refers to the position of the pointer (and the menu)
> with regard to the source actor.

Aha! Thanks. If you wouldn't mind, could you please rename the existing "alignment" to "arrowAlignment" to make it clearer?
Comment 5 Florian Müllner 2011-10-12 23:55:11 UTC 
Created attachment 198889 [details] [review]
popup-menu: Allow adjusting where in the source the arrow point to

(In reply to comment #4)
> Aha! Thanks. If you wouldn't mind, could you please rename the existing
> "alignment" to "arrowAlignment" to make it clearer?

Sure.
Comment 6 Jasper St. Pierre (not reading bugmail) 2011-10-13 00:47:15 UTC 
Review of attachment 198889 [details] [review]:

I was thinking about the boxPointer itself, but sure, go for it.
Comment 7 Florian Müllner 2011-10-13 13:08:37 UTC 
(In reply to comment #6)
> I was thinking about the boxPointer itself, but sure, go for it.

Oh, OK - I changed the property name in boxPointer as well before pushing :)