After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659202 - power: missing break
power: missing break
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-16 02:06 UTC by Matthias Clasen
Modified: 2011-09-16 07:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matthias Clasen 2011-09-16 02:06:42 UTC 
case GSD_POWER_ACTION_SHUTDOWN:

in gsd-power-manager.c:2048 is missing a break;
If the fall through is intentional, there should be a comment saying so.
Comment 1 Richard Hughes 2011-09-16 07:58:53 UTC 
Good catch:

commit e1e652972e9dc47839fd5f3cbfad3dfbeabc29c5
Author: Richard Hughes <richard@hughsie.com>
Date:   Fri Sep 16 08:58:11 2011 +0100

    power: Don't fall through the switch statement when shutting down
    
    Resolves https://bugzilla.gnome.org/show_bug.cgi?id=659202