After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659194 - build: Fix rule to create .service files
build: Fix rule to create .service files
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: building
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-15 22:17 UTC by Vincent Untz
Modified: 2011-09-16 07:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Fix rule to create .service files (1009 bytes, patch)
2011-09-15 22:17 UTC, Vincent Untz
committed Details | Review

Description Vincent Untz 2011-09-15 22:17:36 UTC
Look at org.gnome.Shell.HotplugSniffer.service that is installed, and cry. The rule to create .service files is broken: it always creates the files based on org.gnome.Shell.CalendarServer.service.in.
Comment 1 Vincent Untz 2011-09-15 22:17:39 UTC
Created attachment 196676 [details] [review]
build: Fix rule to create .service files

It was always taking the first .service.in file to create all .service
files: org.gnome.Shell.CalendarServer.service.in was the only one being
used.
Comment 2 Colin Walters 2011-09-16 02:13:25 UTC
Review of attachment 196676 [details] [review]:

Looks good, thanks.  I did cry.
Comment 3 Vincent Untz 2011-09-16 07:21:59 UTC
Comment on attachment 196676 [details] [review]
build: Fix rule to create .service files

Pushed.