After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659109 - Mark bootable mounts as such
Mark bootable mounts as such
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: [obsolete] gdu volume monitor
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-15 01:38 UTC by Zeeshan Ali
Modified: 2011-09-19 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdu volume monitor: Mark bootable mounts as such (3.08 KB, patch)
2011-09-15 01:38 UTC, Zeeshan Ali
none Details | Review
gdu volume monitor: Mark bootable mounts as such (3.06 KB, patch)
2011-09-19 14:19 UTC, Zeeshan Ali
none Details | Review

Description Zeeshan Ali 2011-09-15 01:38:28 UTC
Add appropriate content-type for bootable mounts. Although 'bootability'
information is coming from libosinfo[1], we are not adding a dependency
on it with this patch since libosinfo sets a boolean property on the udev
device for us. We can then just query that property using gudev.

[1] https://fedorahosted.org/libosinfo/
Comment 1 Zeeshan Ali 2011-09-15 01:38:30 UTC
Created attachment 196573 [details] [review]
gdu volume monitor: Mark bootable mounts as such
Comment 2 Bastien Nocera 2011-09-15 09:27:44 UTC
It should be a udisks property instead, I would think. Looking up devices by device node doesn't sound good when you have access to its sysfs path.
Comment 3 Zeeshan Ali 2011-09-15 10:45:44 UTC
(In reply to comment #2)
> It should be a udisks property instead, I would think. 

I patched udisks first but David Zeuthen insisted that this go in gvfs and Alex was ok with that.

> Looking up devices by
> device node doesn't sound good when you have access to its sysfs path.

I don't see any gdu_device_get_sysfs_path().
Comment 4 Bastien Nocera 2011-09-15 13:23:14 UTC
udisks shows things like:

Showing information for /org/freedesktop/UDisks/devices/sr0
  native-path:                 /sys/devices/pci0000:00/0000:00:1f.2/host1/target1:0:0/1:0:0:0/block/sr0
  device:                      11:0
  device-file:                 /dev/sr0
    presentation:              /dev/sr0
    by-id:                     /dev/disk/by-id/ata-Slimtype_BD_E_DL4ETS_1037763
    by-path:                   /dev/disk/by-path/pci-0000:00:1f.2-scsi-1:0:0:0

Not certain how those are exposed in gdu.
Comment 5 Zeeshan Ali 2011-09-19 14:19:39 UTC
Created attachment 196948 [details] [review]
gdu volume monitor: Mark bootable mounts as such

Add appropriate content-type for bootable mounts. Although 'bootability'
information is coming from libosinfo[1], we are not adding a dependency
on it with this patch since libosinfo sets a boolean property on the udev
device for us. We can then just query that property using gudev.

[1] https://fedorahosted.org/libosinfo/
Comment 6 Alexander Larsson 2011-09-19 14:53:15 UTC
pushed.