Created attachment 196525 [details] [review]
patch

Context:
last 0.10 commit in git
goot plugins => udpsink

When debug output is enabled, we get a warning "could not get udp buffer size".

If we ask to set the buffer size, the code seems to no be able to do right (not tested).

In the source code, set/getsockopt( ..., SO_SNDBUF, ...) fails because the first argument is wrong. We have to use sink->sock and not sink->sockfd.

A patch is attached.

By the way, on gst/udp/gstmultiudpsink.c line 630, we have:
           msg.msg_name = (void *) &client->theiraddr;
           msg.msg_namelen = sizeof (client->theiraddr);
           ret = sendmsg (*client->sock, &msg, 0);

So, we use sizeof(sockaddr_storage) in struct msghdr and, in my opinion, it is not correct. For shure, this not works on osx with IP4 addresses. So, I put a TODO in the patch.

Command used to produce the problem on osx:
gst-launch-0.10 videotestsrc ! video/x-raw-rgb,framerate=30/1 ! ffmpegcolorspace ! vp8enc speed=2 ! rtpvp8pay ! udpsink port=1234 host=192.168.1.34 sync=false async=false --gst-debug=multiudpsink:9