After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659060 - add gnome-contacts to default favourites
add gnome-contacts to default favourites
Status: RESOLVED NOTABUG
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 659040
 
 
Reported: 2011-09-14 14:19 UTC by Matthias Clasen
Modified: 2011-10-07 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
schema: Add gnome-contacts to default favourites (1.27 KB, patch)
2011-09-16 18:46 UTC, Florian Müllner
reviewed Details | Review

Description Matthias Clasen 2011-09-14 14:19:52 UTC
Since contacts are a big feature in 3.2, and gnome-contacts is one of the first 'new' apps, it would make sense to have it in the dash from the start.
Comment 1 Alexander Larsson 2011-09-16 14:15:34 UTC
Is this something i can do, or is it a pure shell change?
Comment 2 Florian Müllner 2011-09-16 15:01:30 UTC
(In reply to comment #1)
> Is this something i can do, or is it a pure shell change?

It's a changed default value in the org.gnome.shell schema, so a pure shell change.
Comment 3 Florian Müllner 2011-09-16 18:46:21 UTC
Created attachment 196769 [details] [review]
schema: Add gnome-contacts to default favourites

Here we go ...
Comment 4 drago01 2011-09-16 19:59:19 UTC
Review of attachment 196769 [details] [review]:

Code looks fine, but doesn't it need approval due to ui-freeze?

(And we probably should calm down a bit 'new fancy app' -> default favorites; might end up with a crowed dash if we overdo it).
Comment 5 Bastien Nocera 2011-09-18 11:04:53 UTC
Seems a bit weird that it would show up there, there's already an access path through the search feature in the shell.
Comment 6 Matthias Clasen 2011-09-18 20:06:24 UTC
its a question for the designers
Comment 7 Florian Müllner 2011-10-07 14:42:48 UTC
From #gnome-design:

<fmuellner> can i get a quick decision on bug 659060?
<mccann> what do we have there now?
<hadess> -      <default>[ 'epiphany.desktop', 'evolution.desktop', 'empathy.desktop', 'rhythmbox.desktop', 'shotwell.desktop', 'libreoffice-writer.desktop', 'nautilus.desktop', 'gnome-documents.desktop' ]</default>
<fmuellner> mccann: fwiw, I think there's a valid point in that we already have contacts search in the shell and don't really need it in the dash
<mccann> fmuellner: yeah
<mccann> also it isn't really done


So let's not do this ...