After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659029 - Clipping problem
Clipping problem
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-14 10:06 UTC by Lionel Landwerlin
Modified: 2011-09-14 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Clip problem (10.31 KB, image/png)
2011-09-14 10:06 UTC, Lionel Landwerlin 		  Details
cogl-journal: Fix software clipping for non-intersecting rectangles (1.29 KB, patch)
2011-09-14 10:20 UTC, Neil Roberts 		accepted-commit_now Details | Review

Description Lionel Landwerlin 2011-09-14 10:06:40 UTC 
Created attachment 196477 [details]
Clip problem

Using test-clip in clutter, draw to rectangles that do not intersect.
Comment 1 Neil Roberts 2011-09-14 10:20:28 UTC 
Created attachment 196479 [details] [review]
cogl-journal: Fix software clipping for non-intersecting rectangles

When the clip contains two rectangles which do not intersect it was
generating a clip bounds where the bottom-right corner was above or to
the left of the top-left corner. This would end up allowing the pixels
between the two rectangles instead of clipping everything like it
should. To fix this there is now an extra check which detects this
situation and just clears the clip bounds to all zeroes in a similar
way to what cogl-clip-stack does.
Comment 2 Robert Bragg 2011-09-14 11:49:22 UTC 
Comment on attachment 196479 [details] [review]
cogl-journal: Fix software clipping for non-intersecting rectangles

this looks good to land to me
Comment 3 Neil Roberts 2011-09-14 15:44:43 UTC 
Pushed as e81c1f3e to the Cogl master branch and 52aa386 to the Clutter 1.6 branch.