After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659015 - The mnemonic widget property on the voice page is absent for several widgets
The mnemonic widget property on the voice page is absent for several widgets
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
3.1.x
Other All
: Normal normal
: ---
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-14 07:23 UTC by Hammer Attila
Modified: 2011-09-14 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot for new Orca voice settings subdialog (61.79 KB, image/png)
2011-09-14 07:23 UTC, Hammer Attila 		  Details
Patch for fix this bug (4.33 KB, patch)
2011-09-14 12:14 UTC, Victor Ramirez (virako) 		reviewed Details | Review

Description Hammer Attila 2011-09-14 07:23:33 UTC 
Created attachment 196467 [details]
Screenshot for new Orca voice settings subdialog

Dear Developers,

In Orca preferences dialog in voice page not have accessible labels for some combo boxes, for example the Voice type, Speech System, Speech Sinthesizer, Person combo boxes.
Equals the problem with the Speech Rate, and Speech Pitch sliders.

I sending attachment a screenshot visual how look the dialog.

Attila
Comment 1 Victor Ramirez (virako) 2011-09-14 11:55:02 UTC 
I am creating a pacth for fix this bug, the problem is that some combo boxes are not associate to the labels.
Comment 2 Victor Ramirez (virako) 2011-09-14 12:14:01 UTC 
Created attachment 196486 [details] [review]
Patch for fix this bug
Comment 3 Joanmarie Diggs (IRC: joanie) 2011-09-14 12:54:22 UTC 
Review of attachment 196486 [details] [review]:

Thanks for the patch! 

While your solution addresses the problem as reported, it's not the right solution I'm afraid. Nor is the problem as stated the full/real problem, but rather it is the symptom of the problem.

The real problem is that for some reason on those combo boxes, the mnemonic widget got unset. As a result you cannot move focus to those widgets via the underlined letter and in addition the accessible relation is absent.
Comment 4 Joanmarie Diggs (IRC: joanie) 2011-09-14 12:57:24 UTC 
s/those combo boxes/those widgets/

Anyhoo.... Committed to master: http://git.gnome.org/browse/orca/commit/?id=92fedc9e3bcf935b7988a4d9941f9bbb18736976

Attila thanks for catching that! You rock!!
Comment 5 Hammer Attila 2011-09-14 13:27:14 UTC 
Hy Joanie,

Many thanks the fix.
Very good ydea the new separated interface style for speech related (voice types page tab and speech page tab).
I booting my custom Oneiric live CD, downloading Orca master version and reviewing the new added hungarian label translations.
When I maked new master branch translations, I not see new interface style and not see some label strings only textual labels, or labels with possible using mnemonic letters. :-):-)
Unfortunately I not have installed Oneiric system, because Ubiquity installer now have some inaccessible dialog parts with Orca.

Attila